emboss implement missing parameters #4734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
changed the title
bernt-matthias
force-pushed
the
topic/emboss-param
branch
from
96a20b8 to
97c4a40
Compare
|
This is not a tool suite so it will bump all tools. Are any other changes we want to include here? Should we bump all tool versions? |
nsoranzo
reviewed
Aug 20, 2022
tools/emboss_5/emboss_textsearch.xml
Outdated
| <description>Search sequence documentation. Slow, use SRS and Entrez!</description> | ||
| <expand macro="bio_tools" /> | ||
| <macros> | ||
| <import>macros.xml</import> | ||
| </macros> | ||
| <expand macro="requirements" /> | ||
| <code file="emboss_format_corrector.py" /> | ||
| <command>textsearch -sequence '$input1' -outfile '$out_file1' -pattern '$pattern' -casesensitive -heading $heading -usa $usa -accession $accession -name $search_name -description $description -html | ||
| <command>textsearch | ||
| -sequence '$input1' -outfile '$out_file1' -pattern '$pattern' -casesensitive $casesensitive -heading $heading -usa $usa -accession $accession -name $search_name -description $description -html |
There was a problem hiding this comment.
Maybe split this with one option per line?
There was a problem hiding this comment.
I agree that this would be nicer, but then we should do it consistently in all emboss tools. Don't think that I have the time for this.
This was referenced Aug 29, 2022
there is no such dataype in Galaxy and also the CLI does not support this value. to my surprise the other datatypes all existed in Galaxy .. so lets use them
I have no more changes that I want to include. Don't know about bumping. Can you tell me? |
at some time in the past we changed from 5.0.0.1 to 5.0.0+galaxy2 which was wrong since `"+" < "." == True`. fixes galaxyproject#4829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR: