Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix History Import Bugs #15923

Merged

Conversation

ahmedhamidawan
Copy link
Member

Fixes #15917
Fixes bugs 2 and 3 from #15917:

  1. Just viewing an external shared history adds it to the current user's history switch menu (even without importing it).

^ Now we check against the user_id of the history in UserHistories to prevent that

  1. Importing a new history doesn't potentially set it as current history on server

^ This is because the history was only being added to the state in historyStore. Now, it is also set as current by calling setCurrentHistoryOnServer

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon merged commit dad83ff into galaxyproject:release_23.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants