Importing shared history issue with multiple entry points

[jennaj]

Describe the bug
All three seem related, the example for 2 below seems to reveal what is going on (incorrect target history ID?)

1. "copy" Sharing a History shows up in the other account but doesn't always import (via "copy") but can be reviewed (view).
2. "Import this History case 1" Importing from the "view" above or from admin functions (bug reports) results in double popup windows. First is for your current history and the second is for the actual history being imported.
3. "Import this History case 2" Import via a share link is fine IF logged into an account. If anon, the pop-up is correct but nothing happens.

Galaxy Version and/or server at which you observed the bug
Usegalaxy.org at Galaxy version 23.0.rc1, commit 15ffadeae9988830f891c637a57b65a7ec48c2af

To Reproduce
Steps to reproduce the behavior:

EDIT Martin: I've extracted the first issue below to #15627

**"copy"** Share a history with another account, then attempt to import it via "copy" 1. Go to "Histories shared with me" 2. Click on the menu for a history in that listing 3. Choose "copy" 4. Screen blinks once, then nothing happens. That history does not become the active history and there is no new history added to the User -> History listing.

"Import this History case 1" Share a history with another account, then attempt to import it via "view" -> "import"

1. Go to "Histories shared with me"
2. Click on the menu for a history in that listing
3. Choose "view"
4. Click on the "import" button at the top of the page
5. First pop-up is for the existing active history (!). Can cancel, or proceed to get a copy.
6. Second pop-up (hidden underneath) is for the actual history import, and only useable after the first is cleared.

"Import this History case 2"

1. Go to a web browser that is not logged into UseGalaxy.org
2. Paste in a shared URL (any) or can use this one https://usegalaxy.org/u/jen/h/test-listpaired-convert-dataype
3. Compare with this shared URL https://usegalaxy.eu/u/jenj/h/test-gtn-vgpworkflowtraining (EU will "remember" who last logged in (browser cache?) and show that in the side view, but use that import function anyway. After imported you are in an anonymous session).

Expected behavior (pre 23.0 behavior)

1. "copy" imports a history that becomes the active history
2. "Import this History case 1" imports the target history with a single pop-up (via admin functions or histories-shared-with-me)
3. "Import this History case 2" (URL share link) imports a copy of that history into an account OR an anonymous session. Maybe add another orange reminder banner about "log into an account or create one" or it will be lost.

Screenshots

1. "copy" -

2. "Import this History case 1"

3. "Import this History case 2" (URL share link not signed into an account)

Additional context
The "copy" problem is not 100% a fail. May take several tests to see a pattern but can't find a definitive pattern eg server1 versus server2 or admin/non-admin account combinations. All definitely new in 23.0.

[davelopez]

I think these are 3 different issues:

1. This seems to be broken around Remove legacy history usage from js-modules #14638, I'm not sure how to properly fix this since the copy dialog is now on Vue but this grid is still Backbone and Backbone gives me the chills. Maybe another folk from the UI/UX team can fix this easily?
2. This should be fixed in [23.0] Fix duplicated Copy History dialog in Shared Histories #15619
3. I may not have understood the problem correctly, but I cannot reproduce this in 23.0 locally. I tried, as an anonymous user (incognito mode), to import a History from a link and the imported history replaced the default history successfully.
   

[jennaj]

Thanks @davelopez -- I retested the third one. I'm working on UseGalaxy.org with a Mac running OS Monterey 12.6.1 and Safari. Maybe the issue only shows up on the public site?

URL_Import_Screen.Recording.2023-02-20.at.9.21.47.AM.mov

[davelopez]

Thanks! I think I understand now better the last issue from your video.
What happens if you go to the "Home" after the import? Is the new imported history not there? (This is what I understood as the issue)
Or are you expecting to be automatically redirected to the "Home" after the import?

[jennaj]

What happens if you go to the "Home" after the import? Is the new imported history not there? (This is what I understood as the issue)

"Home" goes to the history in an anon account. But not sure someone who had a share link would understand what to do at that point. Example: clicking on a link in a publication

Or are you expecting to be automatically redirected to the "Home" after the import?

Yes, this is what I was expecting. I think it is much more clearer about what is going on, and making it as easy as possible for someone new to get started is important.

---

The landing page from a shared history is slightly different. If that was on purpose (moving the import button?), maybe that is where this was introduced? The extra details are also super useful, in particular the size of the history (will this blow up my account or not, etc). The annotation field is lost (whether populated or not) but tags will show up if the history has any.

22.05 at EU

23.1 at ORG

[jennaj]

Update:

I'm not getting a double-popup for the history import anymore, but after I do import a shared history it "appears" to be the active history but really isn't.

How to reproduce:

1. Import a history into Galaxy while logged in
2. Click "rerun" for any of the jobs
3. Tool form loads up, but the input datasets will be chosen from whatever history was originally the "active" history (or, show up as non available)
4. Use the Switch-to-history function or User -> Histories and notice that the newly imported history is not the active history

[mvdbeek]

• Tool form loads up, but the input datasets will be chosen from whatever history was originally the "active" history (or, show up as non available)

That's how it has to work, right ? Otherwise it's not a rerun.

item 4 though does seem buggy.

[jennaj]

That's how it has to work, right ? Otherwise it's not a rerun.
item 4 though does seem buggy.

Sorry, this was difficult to explain, will try again: The rerun form is brought up correctly but none of the original inputs are available because that imported history is not actually active (despite loading into the right history panel). Using the history refresh doesn't swap the history. Reloading the entire webpage will bring up the correct active history (whatever was active before the import).

That is how I found item 4.

[ahmedhamidawan]

Update:

I'm not getting a double-popup for the history import anymore, but after I do import a shared history it "appears" to be the active history but really isn't.

How to reproduce:

1. Import a history into Galaxy while logged in
2. Click "rerun" for any of the jobs
3. Tool form loads up, but the input datasets will be chosen from whatever history was originally the "active" history (or, show up as non available)
4. Use the Switch-to-history function or User -> Histories and notice that the newly imported history is not the active history

@jennaj This has been fixed in #15923

[davelopez]

I think all those issues are fixed now, if not please open a new issue :)