-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy history usage from js-modules #14638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1cd60fe
to
60a9658
Compare
…able in current history dropdown
e060ace
to
abd924e
Compare
abd924e
to
542be34
Compare
6 tasks
bgruening
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the history and the libraries and it seems to work well.
Thanks @guerler
Thanks @guerler! |
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #14630. Decouples remaining js-modules from legacy history as another step towards its removal. The following is a list of modules which need to be decoupled. This PR also contains fixes and simplifications for the history store. With these changes details of a history are not deleted if in a consecutive request only obtains partial data (summary serialization) from the backend. Additionally this PR resolves the code duplication of collection builders from the library dataset js-modules.
There are two remaining makos which use the legacy history. These are the history's display and embedded makos which will be refactored in a follow-up. Initially this PR attempted to include these changes but it makes more sense to separate the two.
How to test the changes?
(Select all options that apply)
License