Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy history usage from js-modules #14638

Merged
merged 13 commits into from
Sep 21, 2022

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 16, 2022

Follow-up #14630. Decouples remaining js-modules from legacy history as another step towards its removal. The following is a list of modules which need to be decoupled. This PR also contains fixes and simplifications for the history store. With these changes details of a history are not deleted if in a consecutive request only obtains partial data (summary serialization) from the backend. Additionally this PR resolves the code duplication of collection builders from the library dataset js-modules.

  • Data library
  • History view
  • History grid

There are two remaining makos which use the legacy history. These are the history's display and embedded makos which will be refactored in a follow-up. Initially this PR attempted to include these changes but it makes more sense to separate the two.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Sep 16, 2022
@guerler guerler added this to the 22.09 milestone Sep 16, 2022
@guerler guerler force-pushed the revise_history_view branch 3 times, most recently from 1cd60fe to 60a9658 Compare September 17, 2022 05:15
@guerler guerler force-pushed the revise_history_view branch 2 times, most recently from e060ace to abd924e Compare September 20, 2022 00:32
@guerler guerler force-pushed the revise_history_view branch from abd924e to 542be34 Compare September 20, 2022 00:34
@guerler guerler changed the title Remove legacy history from code base Remove legacy history usage from js-modules Sep 20, 2022
@guerler guerler marked this pull request as ready for review September 20, 2022 02:29
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the history and the libraries and it seems to work well.

Thanks @guerler

@mvdbeek mvdbeek merged commit d5c9cc6 into galaxyproject:dev Sep 21, 2022
@mvdbeek
Copy link
Member

mvdbeek commented Sep 21, 2022

Thanks @guerler!

@guerler guerler deleted the revise_history_view branch September 21, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants