Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated display structured history view #14630

Merged
merged 11 commits into from
Sep 16, 2022

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 15, 2022

This PR removes the display structured view component, controller endpoint and route. Having talked to several contributors, we recognized that this feature has little utility and does not work for larger histories. It also utilized and outdated mix between backend produced html strings and a client-side patching mechanism. Additionally this PR removes the beta toggle switch, which used to allow switching between the legacy and the current history. This is a step towards finally removing the legacy history from the code base.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Sep 15, 2022
@guerler guerler added this to the 22.09 milestone Sep 15, 2022
@guerler guerler marked this pull request as ready for review September 15, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants