Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published Histories Bugs #15917

Closed
ahmedhamidawan opened this issue Apr 7, 2023 · 1 comment · Fixed by #17444
Closed

Published Histories Bugs #15917

ahmedhamidawan opened this issue Apr 7, 2023 · 1 comment · Fixed by #17444

Comments

@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Apr 7, 2023

Spotted a few bugs with the /histories/list_published view:

1. In a shared history (only in the case where it's owned by another user), Collections are blank on expand

Screen.Recording.2023-04-07.at.3.28.52.PM.mov

2. Just viewing an external shared history adds it to the current user's history switch menu (even without importing it).

This is temporary until the state refreshes. When that history is available in the switch history menu, the current user (only if they are an admin) can modify the history, make deletions and changes (even delete the whole history), affecting the external user's actual history.

Screen.Recording.2023-04-07.at.5.26.40.PM.mov

3. Importing a new history doesn't potentially set it as current history on server (reported by @natefoo in @galaxyproject/wg-uiux chat)


Galaxy Version and/or server at which you observed the bug
Galaxy Version: 23.0 and dev

To Reproduce
Steps to reproduce the behavior:
Replicate steps in screencasts above

Expected behavior (corresponding to bugs numbered above)

  1. User should be able to see collection contents in an external, shared/published history.
  2. The external history should not be available in the Switch to History modal.
  3. Imported history must also be set as current on the server.
@hexylena
Copy link
Member

Just encountered the first one, the error message is

{"err_msg":"History is not owned by user","err_code":403003}

in the console if it helps whoever fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants