fix: skip filling unspecified category in the expense form during edit #3431

arjunaj5 · 2025-01-21T08:02:06Z

Clickup

https://app.clickup.com/t/86cxndqh9

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

Bug Fixes
- Improved category selection logic to prevent using 'unspecified' categories when adding or editing expenses.
Tests
- Activated the test suite for the CardStatsComponent and temporarily disabled a specific test related to virtual card details.
- Adjusted change detection timing in the FyUserlistModalComponent tests.

coderabbitai · 2025-01-21T08:02:13Z

Warning

Rate limit exceeded

@arjunaj5 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 042d801 and 06e2987.

📒 Files selected for processing (1)

src/app/fyle/dashboard/card-stats/card-stats.component.spec.ts (4 hunks)

Walkthrough

The getSelectedCategory method in the AddEditExpensePage class has been refined to improve category selection. An additional condition has been added to filter out categories marked as 'unspecified', ensuring that only valid categories are processed. This change enhances the integrity of the category selection process without altering the overall structure of the method.

Changes

File	Change Summary
`src/app/fyle/add-edit-expense/add-edit-expense.page.ts`	Updated `getSelectedCategory` method to exclude 'unspecified' categories by adding a lowercase check on `fyle_category`
`src/app/fyle/dashboard/card-stats/card-stats.component.spec.ts`	Activated the test suite for `CardStatsComponent` and disabled the test for setting `virtualCardDetails$` by changing `it` to `xit`.
`src/app/shared/components/fy-userlist/fy-userlist-modal/fy-userlist-modal.component.spec.ts`	Removed `fixture.detectChanges();` from `ngAfterViewInit()` method to alter change detection timing.

Possibly related PRs

fix: fix reference for system_category field to make sub categories visible in Mileage Form #3215: This PR modifies the logic related to category filtering, which is relevant to the changes made in the getSelectedCategory method of the main PR, as both involve handling category data.
fix: fixed txnField cost center is_mandatory issue #3248: Similar to the main PR, this PR updates the filtering logic in the getSubCategories method to use fyle_category, which aligns with the changes made in the getSelectedCategory method.
fix: remove unmatch personal card feature #3265: This PR also involves changes to category handling, specifically in the context of personal cards, which may relate to the overall category management discussed in the main PR.

Suggested labels

size/S

Suggested reviewers

Chethan-Fyle

Poem

In the land of code, where logic does sway,
'Unspecified' categories, now kept at bay! 🚫
With a twist of the code, and a bouncer's finesse,
Only the finest categories, we now assess! 🌟
Rajini's touch makes the selection divine,
In the world of expenses, everything will shine! 💥

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-21T12:57:31Z

Unit Test Coverage	%	values
Statements	96.17%	( 19349 / 20119 )
Branches	91.24%	( 10677 / 11702 )
Functions	94.52%	( 5761 / 6095 )
Lines	96.23%	( 18474 / 19197 )

#3431) * skip filling unspecified category in the expense form during edit * fix flaky test, get more tests * minor * stupid lint

* fix: Home page cleanup (#3427) * intial fixes * test fix * fixes 2 * at on to date change * expense report fix * sentence case change * letter space change * Reciept sentence case * final fix for fix1 --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * fix: Preference header hide fix (#3433) * intial fixes --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * hide header fix --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * fix: skip filling unspecified category in the expense form during edit (#3431) * skip filling unspecified category in the expense form during edit * fix flaky test, get more tests * minor * stupid lint * sentry fix (#3434) Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * initial push * initial push --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> Co-authored-by: Arjun <arjunmuraliknr@gmail.com>

* fix: Sentence case Changes (#3442) * fix: Home page cleanup (#3427) * intial fixes * test fix * fixes 2 * at on to date change * expense report fix * sentence case change * letter space change * Reciept sentence case * final fix for fix1 --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * fix: Preference header hide fix (#3433) * intial fixes --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * hide header fix --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * fix: skip filling unspecified category in the expense form during edit (#3431) * skip filling unspecified category in the expense form during edit * fix flaky test, get more tests * minor * stupid lint * sentry fix (#3434) Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> * initial push * initial push --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> Co-authored-by: Arjun <arjunmuraliknr@gmail.com> * change back to old --------- Co-authored-by: Mohammed farhan K <mohammedfarhank@Mohammeds-MacBook-Air.local> Co-authored-by: Arjun <arjunmuraliknr@gmail.com>

skip filling unspecified category in the expense form during edit

649067e

arjunaj5 requested a review from Chethan-Fyle as a code owner January 21, 2025 08:02

arjunaj5 requested a review from mvaishnavi January 21, 2025 08:02

github-actions bot added the size/XS Extra Small PR label Jan 21, 2025

mvaishnavi approved these changes Jan 21, 2025

View reviewed changes

arjunaj5 added 3 commits January 21, 2025 18:06

fix flaky test, get more tests

3a4a753

minor

042d801

stupid lint

06e2987

arjunaj5 merged commit 0caab7a into master Jan 21, 2025
5 checks passed

arjunaj5 added a commit that referenced this pull request Jan 22, 2025

fix: skip filling unspecified category in the expense form during edit (

54b6d94

#3431) * skip filling unspecified category in the expense form during edit * fix flaky test, get more tests * minor * stupid lint

coderabbitai bot mentioned this pull request Jan 30, 2025

fix: send only name and value in check_policies and expenses calls #3459

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: skip filling unspecified category in the expense form during edit #3431

fix: skip filling unspecified category in the expense form during edit #3431

arjunaj5 commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Jan 21, 2025

fix: skip filling unspecified category in the expense form during edit #3431

fix: skip filling unspecified category in the expense form during edit #3431

Conversation

arjunaj5 commented Jan 21, 2025 • edited by coderabbitai bot Loading

Clickup

Code Coverage

UI Preview

Summary by CodeRabbit

coderabbitai bot commented Jan 21, 2025 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Jan 21, 2025

arjunaj5 commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)