Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip filling unspecified category in the expense form during edit #3431

Merged
merged 4 commits into from
Jan 21, 2025
Merged

fix: skip filling unspecified category in the expense form during edit #3431

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
649067e
skip filling unspecified category in the expense form during edit
arjunaj5 Jan 21, 2025
3a4a753
fix flaky test, get more tests
arjunaj5 Jan 21, 2025
042d801
minor
arjunaj5 Jan 21, 2025
06e2987
stupid lint
arjunaj5 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/fyle/add-edit-expense/add-edit-expense.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,8 @@ export class AddEditExpensePage implements OnInit {
getSelectedCategory(): Observable<OrgCategory> {
return this.etxn$.pipe(
switchMap((etxn) => {
if (etxn.tx.org_category_id) {
// filter out unspecified category as it is not a valid category
if (etxn.tx.org_category_id && etxn.tx.fyle_category?.toLowerCase() !== 'unspecified') {
return this.categoriesService.getCategoryById(etxn.tx.org_category_id);
} else {
return of(null);
Expand Down
Loading