fix: fixed txnField cost center is_mandatory issue

[devendrafyle]

Clickup

https://app.clickup.com/t/86cwxxpmy

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for cost center and purpose fields to prevent runtime errors.

• New Features

  • Enhanced conditional rendering for labels and mandatory indicators based on data availability.

[coderabbitai]

Walkthrough

Isme kya hua hai bhai? add-edit-per-diem.page.html file ke HTML template mein kuch badlav kiye gaye hain. Null-safe navigation operators (?.) add kiye gaye hain taaki agar txnFields.cost_center_id ya txnFields.purpose undefined ho, toh koi error na aaye. Conditional rendering ko bhi thoda sudhara gaya hai, jisse labels aur mandatory indicators sirf tab dikhai denge jab unki properties present ho. Control flow wahi hai, bas template ki robustness ko improve kiya gaya hai.

Changes

File Path	Change Summary
src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.html	Added null-safe navigation operators and refined conditional rendering for cost center and purpose fields.

Possibly related PRs

• fix: If the org vendor list is empty, auto code the extracted vendor #3218: Modifies the AddEditExpensePage component, enhancing vendor options handling, similar to the main PR.
• fix: toggle and page visibility for Virtual Cards #3240: Updates visibility logic for the "Add Corporate Card" CTA, related to conditional rendering changes in the main PR.
• fix: fix CTA visibility for Add Corporate Card CTA #3243: Addresses visibility of the "Add Corporate Card" CTA, linking to the main PR's focus on template robustness.

Suggested reviewers

• Chethan-Fyle
• Dimple16
• suyashpatil78

"In the world of code, we navigate with care,
Null-safe operators, a developer's prayer.
Conditional rendering, now clearer and bright,
Making our templates a beautiful sight!
With every small change, we dance and we cheer,
Code's a comedy show, let's give it a cheer!" 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 81c9d0d and 161eba3.

📒 Files selected for processing (1)

• src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.html (1 hunks)

🔇 Additional comments (1)

src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.html (1)

420-420: Ekdum mast conditional check lagaya hai bhai!

The condition txnFields.cost_center_id?.is_mandatory || isExpandedView properly handles both mandatory and expanded view cases.

[coderabbitai]

🧹 Nitpick (assertive)

Arre wah! Template binding ka kamaal dekho!

The field name, mandatory flag, and placeholder are now properly bound using the safe navigation operator (?.). This prevents null reference errors when txnFields data is loading.

Consider adding an aria-label for better accessibility:

 <app-virtual-select
   [cacheName]="'perDiemCostCenterCache'"
   [label]="txnFields.cost_center_id?.field_name  | ellipsis: 30"
   [mandatory]="txnFields.cost_center_id?.is_mandatory"
   [options]="costCenters"
   [selectModalHeader]="'Select Cost Center'"
   [recentlyUsed]="recentCostCenters"
   formControlName="costCenter"
+  [attr.aria-label]="txnFields.cost_center_id?.field_name"
   [placeholder]="txnFields.cost_center_id?.placeholder | ellipsis: 30"
 >

Also applies to: 434-434

[github-actions]

Unit Test Coverage	%	values
Statements	95.94%	( 19166 / 19975 )
Branches	91.1%	( 10554 / 11584 )
Functions	94.34%	( 5719 / 6062 )
Lines	95.98%	( 18295 / 19061 )