fix: Added the regex for discarding the sentry issues #3269

devendrafyle · 2024-11-19T07:47:51Z

Clickup

https://app.clickup.com/t/86cx3rrh6

Code Coverage

Please add code coverage here

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

Bug Fixes
- Enhanced error handling by expanding the error patterns ignored by Sentry, improving clarity in error reporting.

coderabbitai · 2024-11-19T07:48:00Z

Walkthrough

The changes in this pull request enhance the Sentry error handling configuration in the src/main.ts file. The ignoreErrors array in the Sentry.init method has been expanded to include new error patterns, including specific string literals and regular expressions. This adjustment allows Sentry to ignore a wider range of non-critical errors, improving the clarity of error reporting while maintaining the existing functionality of the beforeSend function.

Changes

File	Change Summary
`src/main.ts`	Expanded `ignoreErrors` array in `Sentry.init` to include additional error patterns for better error handling.

Possibly related PRs

feat: add mobile app release version in Sentry issues #3249: Modifies the src/main.ts file to update the Sentry configuration, specifically changing the release property.
feat: Removing url query params from Http exception for correct grouping of issues in Sentry #3250: Introduces a new function for cleaning HTTP exception URLs and updates the Sentry configuration.
fix: LIVE_UPDATE_APP_VERSION for Sentry release instead of FYLE_MOBILE_RELEASE_VERSION #3264: Changes the Sentry release version to a dynamic environment variable.
fix: adding live update version for sentry release in build script #3267: Affects the build script related to Sentry releases.

Suggested labels

size/S

Suggested reviewers

Aniruddha-Shriwant
Chethan-Fyle
arjunaj5

In the code, we dance and play,
Ignoring errors, come what may!
Sentry's new tricks, oh what a sight,
Clarity shines, errors take flight!
With regex and strings, we pave the way,
For smoother reports, hip-hip-hooray! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 959c37d and 2c9c1de.

📒 Files selected for processing (1)

src/main.ts (1 hunks)

🔇 Additional comments (1)

src/main.ts (1)

42-51: 🛠️ Refactor suggestion

Listen here, partner! Your error patterns need some style, Thalaiva style! 🕶️

The patterns are working but let me tell you something with swag:

You've mixed string literals and regex patterns like mixing rice with curry. Let's make it consistent!
Those inline comments are good, but they're hiding in the shadows like a villain. Let's make them shine!
Some patterns might be too specific, making them miss similar errors like missing a punch in an action scene!

Here's how we roll in style:

  ignoreErrors: [
+   // Basic error captures
    'Non-Error exception captured',
    'Non-Error promise rejection captured',
    'unhandledError',
+
+   // Geocoding and Maps related errors
-   /Could not load "geocoder"/,
+   /Could not load ["']geocoder["']/,
-   /ChunkLoadError: Loading chunk \d+ failed/,
+   /ChunkLoadError: Loading chunk/,
+
+   // Generic error patterns
    /0 Unknown Error/,
-   /The Google Maps JavaScript API could not load/,
+   /Google Maps JavaScript API could not load/,
-   /kCLErrorDomain error/,
+   /kCLErrorDomain error \d+/,
  ],

Mind-blowing changes, right? 🎭 Let me explain like a boss:

Grouped related errors together for better readability
Made regex patterns more flexible to catch similar errors
Added section comments to explain the error categories

Let's verify if we're not missing any errors, style:

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

devendrafyle · 2024-11-19T07:49:17Z

src/main.ts

+    /Could not load "geocoder"/,
+    /ChunkLoadError: Loading chunk \d+ failed/,
+    /Http failure response for .*: 0 Unknown Error/,
+    /unhandledError/,
+    /The Google Maps JavaScript API could not load/,


Added regex expression to ignore similar kind of issues

Aniruddha-Shriwant · 2024-11-19T07:52:26Z

src/main.ts

+    'Non-Error promise rejection captured',
+    'Could not load "geocoder"',
+    /Could not load "geocoder"/,
+    /ChunkLoadError: Loading chunk \d+ failed/,


could you add example of how this error title looks like?

Aniruddha-Shriwant · 2024-11-19T07:54:16Z

src/main.ts

+    /Http failure response for .*: 0 Unknown Error/,
+    /unhandledError/,
+    /The Google Maps JavaScript API could not load/,
+    /The operation couldn’t be completed\. \(kCLErrorDomain error \d+\)/,


can't we just add kclErrorDomain error why the earlier text is needed?

to remove only these specific errors, yes kclErrorDomain error will also work

Aniruddha-Shriwant · 2024-11-19T07:55:20Z

src/main.ts

+    /Could not load "geocoder"/,
+    /ChunkLoadError: Loading chunk \d+ failed/,
+    /Http failure response for .*: 0 Unknown Error/,
+    /unhandledError/,


/unhandledError/ -> 'unhandledError' if not using any regex - also move this to top where all strings related error messages are defined

Aniruddha-Shriwant · 2024-11-19T07:56:16Z

src/main.ts

+    'Could not load "geocoder"',
+    /Could not load "geocoder"/,
+    /ChunkLoadError: Loading chunk \d+ failed/,
+    /Http failure response for .*: 0 Unknown Error/,


should we just add 0 Unknown Error? since I've seen this issue occurring while fetching svgs or other files as well

Ok we can do this, in discarded issues I found it for HTTP failure so added this

Aniruddha-Shriwant · 2024-11-19T07:56:57Z

src/main.ts

+    'Could not load "geocoder"',
+    /Could not load "geocoder"/,


what's different in both?

Missed removing this

github-actions · 2024-11-19T08:28:08Z

Unit Test Coverage	%	values
Statements	95.95%	( 19187 / 19996 )
Branches	91.11%	( 10567 / 11597 )
Functions	94.35%	( 5729 / 6072 )
Lines	95.98%	( 18316 / 19082 )

* fix: Added the regex for discarding the sentry issues * Added missed issue to ignore * Updated the errors * minor comments fix

fix: Added the regex for discarding the sentry issues

3e664b5

devendrafyle requested review from Chethan-Fyle and arjunaj5 as code owners November 19, 2024 07:47

devendrafyle requested a review from Aniruddha-Shriwant November 19, 2024 07:47

github-actions bot added the size/XS Extra Small PR label Nov 19, 2024

devendrafyle commented Nov 19, 2024

View reviewed changes

Aniruddha-Shriwant reviewed Nov 19, 2024

View reviewed changes

Added missed issue to ignore

959c37d

Aniruddha-Shriwant reviewed Nov 19, 2024

View reviewed changes

devendrafyle added 2 commits November 19, 2024 13:31

Updated the errors

a2ebe84

minor comments fix

2c9c1de

Chethan-Fyle approved these changes Nov 19, 2024

View reviewed changes

Aniruddha-Shriwant approved these changes Nov 19, 2024

View reviewed changes

devendrafyle merged commit 169b43f into master Nov 19, 2024
10 checks passed

devendrafyle added a commit that referenced this pull request Nov 19, 2024

fix: Added the regex for discarding the sentry issues (#3269)

a5ff931

* fix: Added the regex for discarding the sentry issues * Added missed issue to ignore * Updated the errors * minor comments fix

coderabbitai bot mentioned this pull request Nov 21, 2024

chore: ignoring plugins not implemented on web errors in Sentry #3278

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Added the regex for discarding the sentry issues #3269

fix: Added the regex for discarding the sentry issues #3269

devendrafyle commented Nov 19, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 19, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

devendrafyle Nov 19, 2024

Aniruddha-Shriwant Nov 19, 2024

Aniruddha-Shriwant Nov 19, 2024

devendrafyle Nov 19, 2024

Aniruddha-Shriwant Nov 19, 2024

devendrafyle Nov 19, 2024

Aniruddha-Shriwant Nov 19, 2024

devendrafyle Nov 19, 2024

Aniruddha-Shriwant Nov 19, 2024

devendrafyle Nov 19, 2024

github-actions bot commented Nov 19, 2024

fix: Added the regex for discarding the sentry issues #3269

fix: Added the regex for discarding the sentry issues #3269

Conversation

devendrafyle commented Nov 19, 2024 • edited by coderabbitai bot Loading

Clickup

Code Coverage

UI Preview

Summary by CodeRabbit

coderabbitai bot commented Nov 19, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 19, 2024

devendrafyle commented Nov 19, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)