fix: LIVE_UPDATE_APP_VERSION for Sentry release instead of FYLE_MOBILE_RELEASE_VERSION #3264
Conversation
…E_RELEASE_VERSION
Aniruddha-Shriwant
requested review from
Chethan-Fyle and
arjunaj5
as code owners
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -38,7 +38,7 @@ Sentry.init({ | |||
| dsn: environment.SENTRY_DSN, | |||
| integrations: [], | |||
| tracesSampleRate: 0.1, | |||
| release: 'please-replace-your-mobile-app-version', | |||
There was a problem hiding this comment.
discussed here, LIVE_UPDATE_APP_VERSION - will have updated version always, so using that key
There was a problem hiding this comment.
my .env's LIVE_UPDATE_APP_VERSION 5.13.1 is reflected in Sentry properly ✌🏻
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range comments (1)
src/main.ts (1)
Line range hint
38-47: Superstar suggestion for better monitoring!Like how I make my grand entries perfectly timed, we should add performance monitoring to Sentry!
Consider enabling Sentry's Performance Monitoring by adding these integrations:
Sentry.init({ dsn: environment.SENTRY_DSN, - integrations: [], + integrations: [ + new Sentry.BrowserTracing({ + tracingOrigins: ['localhost', 'your-production-domain.com'], + }), + ], tracesSampleRate: 0.1, release: environment.LIVE_UPDATE_APP_VERSION, ignoreErrors: ['Non-Error exception captured', 'Non-Error promise rejection captured'], beforeSend(event) { cleanHttpExceptionUrlsForSentryGrouping(event); return event; }, });When you add performance monitoring, you become the Thalaiva of debugging! 🌟
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
hooks/prebuild.js(0 hunks)src/main.ts(1 hunks)
💤 Files with no reviewable changes (1)
- hooks/prebuild.js
| @@ -38,7 +38,7 @@ Sentry.init({ | |||
| dsn: environment.SENTRY_DSN, | |||
| integrations: [], | |||
| tracesSampleRate: 0.1, | |||
| release: 'please-replace-your-mobile-app-version', | |||
| release: environment.LIVE_UPDATE_APP_VERSION, | |||
There was a problem hiding this comment.
💡 Codebase verification
Mind it! The environment setup needs some punch, macha!
Listen here, the situation is like a movie without a climax! We found LIVE_UPDATE_APP_VERSION in environment.ts, but it's empty like a vacant theater! And the production environment file is missing like my signature sunglasses!
environment.tshasLIVE_UPDATE_APP_VERSION: ''- empty string, not good!environment.prod.tsis completely missing from the stage!
You need to:
- Add proper value to
LIVE_UPDATE_APP_VERSIONin environment.ts - Create environment.prod.ts with the production configuration
- Ensure both files have the correct version setup
Remember: In my style, when Sentry tracks errors, it should know exactly which version caused the trouble!
🔗 Analysis chain
Mind-blowing change, but let's verify the environment setup, boss!
The change from hardcoded version to environment.LIVE_UPDATE_APP_VERSION is stylish! But just like how I verify my stunts, we need to verify this environment variable setup.
Mind it: Make sure this variable is properly set in your environment configuration files, or Sentry won't know which version caused the punch dialogues... err... I mean errors! 🕶️
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify LIVE_UPDATE_APP_VERSION is properly configured
# Check if the variable is defined in environment files
echo "Checking environment files for LIVE_UPDATE_APP_VERSION..."
rg "LIVE_UPDATE_APP_VERSION" src/environments/
Length of output: 234
Script:
#!/bin/bash
# Let's check both environment files to ensure proper configuration
echo "Checking all environment files content..."
echo "=== environment.ts ==="
cat src/environments/environment.ts
echo -e "\n=== environment.prod.ts ==="
cat src/environments/environment.prod.ts
# Let's also check the previous version variable usage
echo -e "\n=== Checking for FYLE_MOBILE_RELEASE_VERSION ==="
rg "FYLE_MOBILE_RELEASE_VERSION" src/environments/
Length of output: 1640
|
Clickup
app.clickup.com
Summary by CodeRabbit
New Features
Bug Fixes