-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding live update version for sentry release in build script #3267
Conversation
WalkthroughThe Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
build_appflow.sh
(1 hunks)
🔇 Additional comments (1)
build_appflow.sh (1)
3-3
:
Mind it! Verify the LIVE_UPDATE_APP_VERSION variable, machan!
The script is now fully dependent on $LIVE_UPDATE_APP_VERSION
being set correctly. This is a critical change that could affect source map uploads to Sentry if the variable is not properly set.
Let me run a quick check with this script, thalaiva:
I suggest adding this validation at the start of the script:
+if [ -z "$LIVE_UPDATE_APP_VERSION" ]; then
+ echo "Error: LIVE_UPDATE_APP_VERSION is not set!"
+ exit 1
+fi
+
ionic capacitor sync --prod --source-map
This reverts commit 3383438.
|
Clickup
app.clickup.com
Summary by CodeRabbit
$LIVE_UPDATE_APP_VERSION
variable.