Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: data import for stock entries #42711

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Aug 11, 2024

System is taking 106 seconds to import 99 stock entries

process_sle method ran 4950 times for 99 stock entries which ideally should execute for 99 times

Screenshot 2024-08-08 at 11 42 58 PM

After Fix

22 seconds to complete 99 stock entries

Screenshot 2024-08-09 at 1 44 49 AM

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Aug 11, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-previous-sle branch 4 times, most recently from 7523acd to 749c581 Compare August 12, 2024 09:37
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-previous-sle branch 7 times, most recently from 8142a4c to 7bc2d3a Compare August 12, 2024 14:00
@rohitwaghchaure rohitwaghchaure changed the title fix: previous SLE query (breaking change) perf: data import for stock entries Aug 13, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-previous-sle branch 3 times, most recently from 9b9b07d to f8f7380 Compare August 19, 2024 05:30
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Aug 19, 2024
@rohitwaghchaure rohitwaghchaure merged commit 1511280 into frappe:develop Aug 19, 2024
12 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Aug 19, 2024
rohitwaghchaure added a commit that referenced this pull request Aug 19, 2024
perf: data import for stock entries (#42711)

(cherry picked from commit 1511280)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 21, 2024
## [15.33.3](v15.33.2...v15.33.3) (2024-08-21)

### Bug Fixes

* Auto Create Serial and Batch Bundle For Outward (backport [#42778](#42778)) ([#42792](#42792)) ([7cc7179](7cc7179))
* backport german translations from develop ([9e9de4c](9e9de4c))
* bank reconcilation tool cost center company filter adding ([cd59940](cd59940))
* Create Sales Order from Quotation for Prospect ([f547bef](f547bef))
* create SO from Quot for Prospect --conflicts ([ec0201c](ec0201c))
* create SO from Quot for Prospect --conflicts ([5d7fb1d](5d7fb1d))
* disable rename from warehouse ([3a1ad6e](3a1ad6e))
* disable rename from warehouse ([40abd82](40abd82))
* dropping index to improve performance (backport [#42820](#42820)) ([#42821](#42821)) ([b24de3e](b24de3e))
* german translations ([751c209](751c209))
* german translations of "HR" ([6f7fdbe](6f7fdbe))
* ignore pricing rule while making DN from Pick List (backport [#42763](#42763)) ([#42768](#42768)) ([aba54ba](aba54ba))
* not able to create the batch (backport [#42784](#42784)) ([#42785](#42785)) ([0f9849e](0f9849e))
* **patch:** replace repost with direct sql to update 'against_voucher ([e420fa9](e420fa9))
* removed extra filter condition ([b84ca04](b84ca04))
* set up filters for dimensions ([abb8866](abb8866))
* translatability of boldened text ([4914481](4914481))
* update the testcase format ([33542cb](33542cb))
* update the testcase format ([549dc28](549dc28))

### Performance Improvements

* asset creation from purchase receipt ([1040198](1040198))
* data import for stock entries (backport [#42711](#42711)) ([#42819](#42819)) ([0344442](0344442))
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Aug 26, 2024
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
(cherry picked from commit 1511280)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/test_stock_entry.py
rohitwaghchaure added a commit that referenced this pull request Aug 26, 2024
* perf: data import for stock entries (#42711)

(cherry picked from commit 1511280)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/test_stock_entry.py

* chore: fix conflicts

* chore: fix linters issue

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 28, 2024
# [14.73.0](v14.72.2...v14.73.0) (2024-08-28)

### Bug Fixes

* call 'process' directly instead of creating 'process_subscripti ([8412938](8412938))
* currency symbol on `amount` field suppose to show as `Company`'s currency not as default company's currency ([333c757](333c757))
* do not copy date fields in opportunity doctype ([5186872](5186872))
* german translations for incoterms ([003653c](003653c))
* get amount with taxes and charges from payment entry ([094411f](094411f))
* same posting date and time, creation causing incorrect balance qty (backport [#42904](#42904)) ([#42919](#42919)) ([c0b5f7c](c0b5f7c))
* specify precision for net_amount ([#39481](#39481)) ([cf34219](cf34219))
* stock reco with incorrect serial numbers ([#42865](#42865)) ([54842ea](54842ea))
* timeout while submitting stock entry (backport [#42929](#42929)) ([#42930](#42930)) ([73eab91](73eab91))
* unsupported operand type(s) for *: 'float' and 'NoneType' (backport [#42916](#42916)) ([#42917](#42917)) ([2f4f2a8](2f4f2a8))
* update dimesions in exchange_gain_loss jv based on base document ([820dcd7](820dcd7))
* Update get_amount to return currency precision grand total ([0c2d7f2](0c2d7f2))
* use of incorrect attribute ([ff14d72](ff14d72))

### Features

* report to identify incorrectly cleared cheques ([c29b95e](c29b95e))

### Performance Improvements

* data import for stock entries (backport [#42711](#42711)) ([#42903](#42903)) ([12d5e24](12d5e24))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant