Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore pricing rule while making DN from Pick List #42763

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  • User has created pricing rule that on purchase of 2 quantity of Item A, they will get 1 free quantity of Item A
  • User has create a sales order for 2 quantity of Item A, on which 1 free quantity of Item A has added in the SO
  • User has created a pick list and he came to know that he has only 2 quantity of Item A available, so he has removed free item
  • User has created Delivery Note and system has added 1 free item automatically which ideally was not picked

Solution

Added option in the pick list to Ignore the pricing rule
Screenshot 2024-08-14 at 1 24 16 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 14, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-support-20061-pl branch 3 times, most recently from 65740f0 to ec5f59a Compare August 14, 2024 09:01
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Aug 14, 2024
@rohitwaghchaure rohitwaghchaure merged commit 0db82ec into frappe:develop Aug 14, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request Aug 14, 2024
rohitwaghchaure added a commit that referenced this pull request Aug 14, 2024
) (#42768)

fix: ignore pricing rule while making DN from Pick List (#42763)

(cherry picked from commit 0db82ec)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 21, 2024
## [15.33.3](v15.33.2...v15.33.3) (2024-08-21)

### Bug Fixes

* Auto Create Serial and Batch Bundle For Outward (backport [#42778](#42778)) ([#42792](#42792)) ([7cc7179](7cc7179))
* backport german translations from develop ([9e9de4c](9e9de4c))
* bank reconcilation tool cost center company filter adding ([cd59940](cd59940))
* Create Sales Order from Quotation for Prospect ([f547bef](f547bef))
* create SO from Quot for Prospect --conflicts ([ec0201c](ec0201c))
* create SO from Quot for Prospect --conflicts ([5d7fb1d](5d7fb1d))
* disable rename from warehouse ([3a1ad6e](3a1ad6e))
* disable rename from warehouse ([40abd82](40abd82))
* dropping index to improve performance (backport [#42820](#42820)) ([#42821](#42821)) ([b24de3e](b24de3e))
* german translations ([751c209](751c209))
* german translations of "HR" ([6f7fdbe](6f7fdbe))
* ignore pricing rule while making DN from Pick List (backport [#42763](#42763)) ([#42768](#42768)) ([aba54ba](aba54ba))
* not able to create the batch (backport [#42784](#42784)) ([#42785](#42785)) ([0f9849e](0f9849e))
* **patch:** replace repost with direct sql to update 'against_voucher ([e420fa9](e420fa9))
* removed extra filter condition ([b84ca04](b84ca04))
* set up filters for dimensions ([abb8866](abb8866))
* translatability of boldened text ([4914481](4914481))
* update the testcase format ([33542cb](33542cb))
* update the testcase format ([549dc28](549dc28))

### Performance Improvements

* asset creation from purchase receipt ([1040198](1040198))
* data import for stock entries (backport [#42711](#42711)) ([#42819](#42819)) ([0344442](0344442))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant