Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: data import for stock entries (backport #42711) #42903

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 26, 2024

System is taking 106 seconds to import 99 stock entries

process_sle method ran 4950 times for 99 stock entries which ideally should execute for 99 times

Screenshot 2024-08-08 at 11 42 58 PM

After Fix

22 seconds to complete 99 stock entries

Screenshot 2024-08-09 at 1 44 49 AM
This is an automatic backport of pull request #42711 done by [Mergify](https://mergify.com).

(cherry picked from commit 1511280)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/test_stock_entry.py
Copy link
Contributor Author

mergify bot commented Aug 26, 2024

Cherry-pick of 1511280 has failed:

On branch mergify/bp/version-14-hotfix/pr-42711
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 1511280464.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/stock/doctype/stock_ledger_entry/test_stock_ledger_entry.py
	modified:   erpnext/stock/stock_ledger.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/stock_entry/test_stock_entry.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the stock label Aug 26, 2024
@rohitwaghchaure rohitwaghchaure merged commit 12d5e24 into version-14-hotfix Aug 26, 2024
9 of 10 checks passed
@rohitwaghchaure rohitwaghchaure deleted the mergify/bp/version-14-hotfix/pr-42711 branch August 26, 2024 08:23
frappe-pr-bot pushed a commit that referenced this pull request Aug 28, 2024
# [14.73.0](v14.72.2...v14.73.0) (2024-08-28)

### Bug Fixes

* call 'process' directly instead of creating 'process_subscripti ([8412938](8412938))
* currency symbol on `amount` field suppose to show as `Company`'s currency not as default company's currency ([333c757](333c757))
* do not copy date fields in opportunity doctype ([5186872](5186872))
* german translations for incoterms ([003653c](003653c))
* get amount with taxes and charges from payment entry ([094411f](094411f))
* same posting date and time, creation causing incorrect balance qty (backport [#42904](#42904)) ([#42919](#42919)) ([c0b5f7c](c0b5f7c))
* specify precision for net_amount ([#39481](#39481)) ([cf34219](cf34219))
* stock reco with incorrect serial numbers ([#42865](#42865)) ([54842ea](54842ea))
* timeout while submitting stock entry (backport [#42929](#42929)) ([#42930](#42930)) ([73eab91](73eab91))
* unsupported operand type(s) for *: 'float' and 'NoneType' (backport [#42916](#42916)) ([#42917](#42917)) ([2f4f2a8](2f4f2a8))
* update dimesions in exchange_gain_loss jv based on base document ([820dcd7](820dcd7))
* Update get_amount to return currency precision grand total ([0c2d7f2](0c2d7f2))
* use of incorrect attribute ([ff14d72](ff14d72))

### Features

* report to identify incorrectly cleared cheques ([c29b95e](c29b95e))

### Performance Improvements

* data import for stock entries (backport [#42711](#42711)) ([#42903](#42903)) ([12d5e24](12d5e24))
@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.73.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants