Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.7.2 Release #461

Merged
merged 79 commits into from
Feb 5, 2019
Merged

2.7.2 Release #461

merged 79 commits into from
Feb 5, 2019

Conversation

y0hami
Copy link
Member

@y0hami y0hami commented Feb 4, 2019

Version 2.7.2 - February 5, 2019

Bugs

  • Modal - Fixed issue which made modals close when dragging the scrollbar Thanks @lubber-de 437
  • Modal - Fixed issue that didn't reactivate the approve and deny event handlers if onHide returned false Thanks @lubber-de 434
  • Icons - Fixed issue causing icon colors to be overwritten by other components text color Thanks @lubber-de 438
  • Icons - Made link and disabled work together correctly Thanks @lubber-de 344
  • Checkbox - Made onChange only call once and not call when set checked is used Thanks @lubber-de 403
  • Dimmer - Show correct scrollbar on inverted dimmers Thanks @lubber-de 431
  • Progress - Fixed bug which showed a slight progress when the progress bar wasn't initialized Thanks @lubber-de 425
  • Progress - Fixed 0% display and "inverted indicating" label color Thanks @lubber-de 412
  • Form Validation - Fixed custom rule not getting checked radio value Thanks @lubber-de 419
  • From Validation - Fixed issue which lead to validation not respecting each field in array inputs Thanks @lubber-de 387
  • Transition - Fixed issues which where caused because the transition module wasn't aware of inline styles and stopped it showing hidden tags like <script> Thanks @lubber-de 357
  • Menu - Fixed bug which made colors not be applied to secondary menus Thanks @lubber-de 409
  • Menu - Fixed labels in secondary pointing menu items being misaligned Thanks @lubber-de 378
  • Menu - Corrected wrong border being applied for inverted pointing menus Thanks @lubber-de 380
  • Menu - Fixed naming conflict with secondary color name Thanks @lubber-de 366
  • Menu - Fixed last item in secondary compact menus not having bottom and top left border radius Thanks @lubber-de 351
  • Menu - Icons in menus with different sizes will keep their auto width Thanks @lubber-de 345
  • Menu - Corrected inverted disabled items in menus Thanks @lubber-de 347
  • Popup - Fixed z-index of popup so it appears above other components Thanks @lubber-de 395 & 350
  • Input - Made inverted transparent input in forms appear white Thanks @lubber-de 392
  • Label - Fixed cursor for link corner label icons Thanks @lubber-de 369
  • Label - Fixed image position/size in labels within menu items Thanks @lubber-de 337
  • Dropdown - Allow a real zero to be a selectable value in 'set selected' Thanks @lubber-de 370
  • Dropdown - Fixed issue which made dropdowns not use the class names from the settings for templates Thanks @lubber-de 358
  • Dropdown - Fixed multi select dropdowns deleting last selected item when deleting text from search input Thanks @lubber-de 352
  • Dropdown - Fixed simple dropdown positioning in vertical menus Thanks @lubber-de 339
  • Dimmer - Fixed issue with blurred dimmer which left z-index stacking side effects Thanks @lubber-de 371
  • Segment - Fixed naming conflict with secondary color name Thanks @lubber-de 366
  • Loader - Fixed elastic loader in Firefox Thanks @lubber-de 363
  • Loader - Fixed default loader color settings for dimmers used with modals Thanks @lubber-de 359
  • Button - Fixed loading icon position while rotating Thanks @lubber-de 361
  • Button - Fixed attached buttons z-index when used under dropdowns in menus Thanks @lubber-de 333
  • Sidebar - Sidebar will now respect a change of the closable setting Thanks @lubber-de 335
  • Table - Fixed colors not being applied to striped, basic, selectable, stacked and definition tables Thanks @lubber-de 332
  • Form - Fixed issue which caused checkboxes and radios with errors to only reset if the first option was selected Thanks @lubber-de 349
  • Form - Fixed issue with inverted loader not being applied to inverted forms (normal loader was applied instead) Thanks @lubber-de 346
  • List - Fixed issue which made some lists turn invisible Thanks @lubber-de 354
  • List - Fixed loading icon position when used as the item point Thanks @lubber-de 336
  • Header - Fixed attached inverted variation not having the same background color as other inverted components Thanks @lubber-de 338
  • Search - Fixed onSelect not returning the correct item when categories was empty Thanks @lubber-de 343

Enhancements

  • Icons - Update icons to FontAwesome 5.7 Thanks @hammy2899 446
  • Reset - Update reset to normalize 8.0.1 Thanks @lubber-de 443
  • Dropdown - Added support for ignoring diacritics while searching Thanks @lubber-de 422
  • Dropdown - Sanitize possible given text values Thanks @lubber-de 420
  • Search - Added support for ignoring diacritics while searching Thanks @lubber-de 422
  • Build - Removed gulp-help dependency (We recommend you use gulp --tasks to list tasks) Thanks @ColinFrick 440
  • Segment - Added stackable horizontal segments Thanks @lubber-de 398
  • Label - Added bottom floated labels Thanks @lubber-de 430
  • Label - Added left and right aligned floated labels Thanks @lubber-de 418
  • Label - Floating labels don't wrap when they have whitespace (especially while including icons) Thanks @lubber-de 388
  • Label - Improved margin placement for icons when placed after text
  • Modal - Added new restoreFocus option to restore focus when a modal closes Thanks @lubber-de 433
  • Text - Added size variants Thanks @lubber-de 414
  • Step - Made grouped steps wrap by default Thanks @lubber-de 397
  • Step - Added icon size variation Thanks @exoego 348
  • List - Added suffixed ordered list variation Thanks @exoego 355
  • List - Made horizontal divided lists wrap by default Thanks @lubber-de 353
  • Input - Added support for error classes on input action buttons (shows red border around button) Thanks @lubber-de 329

lubber-de and others added 30 commits December 24, 2018 18:12
@lubber-de
fix(loader): elastic style had wrong color applied
df5701c
chore(release): 2.7.1
3d40656
@lubber-de
fix(table): increase specificity to make colors work over striped or …
173d336 
…stacked columns
@lubber-de
fix(button): increased size specificity to work with menu item buttons
1489756
@lubber-de
fix(list,icon): adjust position when icon has loading class
80df182
@lubber-de
fix(input): support error class on input action buttons
3cbc515
@lubber-de
feat(label): remove hardcoded color exception "not()" for menu item l…
207e40e 
…abels
@lubber-de
fix(form,segment): inverted variants should get inverted loader properly
6b091f8
@lubber-de
fix(dropdown): fix simple dropdown positioning in vertical menus
ba49f8f
@lubber-de
fix(colors): missing "globals" subpath in optional theme
e347e20
@lubber-de
fix(menu): corrected support for disabled items in inverted menus
5318605
@lubber-de
fix(menu): keep auto width for icon menu sizes
7a204d4
@lubber-de
fix(icon): make link and disabled work together correctly, also suppo…
cef454e 
…rt icon groups
@lubber-de
fix(search): don't increase categoryindex if result was empty
1d8c7ac
fix(step): increase specificity of icon size
23cafb3
@lubber-de
fix(header): should have same background color as other inverted comp…
25f417e 
…onents
@lubber-de
fix(popup): display a popup over a checkbox slider completely
6be2082
@lubber-de
fix(dropdown): multi dropdown deletes last item when removing input/s…
b84b814 
…earch text
@lubber-de
fix(list): horizontal lists wrap nicely on small screens
dbb489c
@lubber-de
fix(menu): last item in secondary compact menu lost left top/bottom b…
b97bd06 
…order radius
@lubber-de
fix(list): missing pseudo-class leads to invisible list item
e1d2098
@lubber-de
fix(form): checkbox and radio (with errors) were only reset if the fi…
6e41efe 
…rst option was selected
@lubber-de
fix(button): z-index on attached buttons was shown above dropdown menu
08e6406
feat(list): add suffixed ordered list variation
6a7352b
@lubber-de
feat(loader,modal): default loader color settings in dimmers affected…
cdfc878 
… loaders in modals
@lubber-de
fix(dropdown): templates should also use dynamic classnames from sett…
26d6689 
…ings
docs(coc): add code of conduct
4ce3c33
@lubber-de
fix(label): adjust image height of image labels in menu items
7ac1cb3
fix(table): increase specificity to make colors work over striped or …
92e1e99 
…stacked columns (#332)
@lubber-de
fix(sidebar): respect a change of closable setting
4de7c51
lubber-de and others added 12 commits January 29, 2019 08:58
@lubber-de
fix(icon): increase color specificity
588067f 
This PR increases color specificity, so icons in links of a `list item` won't be overridden by the default grey

Closes #436
@lubber-de
fix(modal): prevent closing the modal when webkit scrollbar has been …
bdf30a8 
…dragged
@lubber-de
feat(dropdown, search): support to ignore diacritics on search
63a0855 
This PR adds the option `ignoreDiacritics` (default `false` to stay backward compatible) to the dropdown and search module.
When activated, searches will also match results for base diacritic letters. For example when searching for 'a', it will also match 'á' or 'â' or 'å' and so on...
It will also ignore diacritics for the searchterm, so if searching for 'ó', it will match 'ó', but also 'o', 'ô' or 'õ' and so on...

For the dropdown module i also optimized the sorting method to sort `<option>` values to make sure Diacritics Values are ignored in sorted order. See screenshots below

I implemented the easiest, shortest and most effective solution by using the `String().normalize()` method.
As unfortunately IE does not support this, the modules will check support at initialization time and reset the `ignoreDiacritics` setting accordingly, so it behaves as before in such case.
There exists a polyfill to also support IE, so this will be mentioned in the console if needed.
@lubber-de
feat(reset): updated normalize.css to 8.0.1
f7f00d3
feat(icons): update icons to FontAwesome 5.7
a89a747 
Update the icons to FontAwesome 5.7. If you want to see all changes added with this upgrade you can view them in the FA changelog from 5.4.2 to 5.7 https://github.com/FortAwesome/Font-Awesome/blob/cd0029e8bfb4cb905af0e9632b547d245f09280b/CHANGELOG.md#542----2018-10-25

Closes #236
docs(readme): add v3 development message
a8e7eee 
Add message about v3 to readme so new users don't get mislead by the old message
chore(release): rebase with master
983384f
chore(release): update version number
a011585
chore(release): 2.7.2 dist files
4ddb76f
@lubber-de
fix(card): bottom attached colored buttons left blurry grey bottom line
8985330 
Whenever a bottom attached button was used in cards and the card itself had a color, there was always a small 1px blurry grey box-shadow background left, which made it look a bit disturbing. See screenshots

Closes #454
chore(release): update release notes
606ac7c
chore(release): 2.7.2
0d537d6
@y0hami y0hami self-assigned this Feb 4, 2019
@ghost
Copy link

ghost commented Feb 4, 2019

There were the following issues with this Pull Request

  • Commit: 4c9da88
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ColinFrick
ColinFrick previously approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Feb 4, 2019
Merged
Merged
Merged
@ghost
Copy link

ghost commented Feb 4, 2019

There were the following issues with this Pull Request

  • Commit: 4c9da88
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Feb 4, 2019

There were the following issues with this Pull Request

  • Commit: 4c9da88
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

lubber-de
lubber-de approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 7128a93 into master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho prudho approved these changes

@lubber-de lubber-de lubber-de approved these changes

Assignees

@y0hami y0hami

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y0hami @ColinFrick @prudho @lubber-de @liuchunda