Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List] Make horizontal (divided) lists wrap nicely on small screens #353

Merged

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Jan 2, 2019

Description

When displaying the horizontal list in a small screen, the wrapped items have this strange space in the left side instead of perfectly aligning like a grid.

Testcase

https://fomantic-ui.com/elements/list.html#horizontal

  • Shrink the screen, so the examples start to wrap
  • To not forget the divided horizontal variant (which the SUI PR's always forgot), add the divided class manually to one of the horizontal examples to double check the below screenshots

Screenshots

Before

horizontal_list_wrapped_

After

horizontal_list_wrapped_fixed

Closes

Semantic-Org/Semantic-UI#4501

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 2, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 2, 2019
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit dbb489c into fomantic:develop Jan 3, 2019
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 3, 2019
@lubber-de lubber-de deleted the fix/4501/horizontal_list_wrap_alignment branch January 3, 2019 09:04
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 3, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants