-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment] Introducing stackable horizontal segments #398
[Segment] Introducing stackable horizontal segments #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ko2in @lubber-de this will be due to the horizontal divider still being applied. |
@ko2in @hammy2899 ui.horizontal.segments > .segment:first-child {
border-left: none;
} I suggest not doing this for |
…ook when elements wrap
@ko2in @hammy2899 changed it accordingly |
@lubber-de Using pseudo element You can check in this fiddle. |
@ko2in Very nice visual trick to cover that border 👌 , but only if the background has exactly the same color for every segment inside. Also the top and bottom border should not get covered (overlays the vertical dividers by one pixel) http://jsfiddle.net/Lpavt5ek/1/ |
@lubber-de Yes. Not perfect with background. Your fix might be more suitable for this reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added
stackable
variant tohorizontal segments
to make those segments wrap if neededTestcase
http://jsfiddle.net/tmxLgno1/2/
Remove CSS to see usual behavior without stackable support
Screenshot
Normal behavior:
.ui.horizontal.segments
New behavior:
.ui.stackable.horizontal.segments