Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gclient_variables back for linux_license and fix the excluded files #49775

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add gclient_variables back for linux_license and fix the excluded files #49775

merged 1 commit into from
Jan 12, 2024

Conversation

keyonghan
Copy link
Contributor

Last piece to fix: flutter/flutter#141461

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@keyonghan
Copy link
Contributor Author

Waiting for test exemption before adding autosubmit label.

@johnmccutchan
Copy link
Contributor

test-exempt: config change

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
@auto-submit auto-submit bot merged commit 4d936aa into flutter:main Jan 12, 2024
29 checks passed
@keyonghan keyonghan mentioned this pull request Jan 12, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 12, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2024
@engine-flutter-autoroll
4d936aadb Add gclient_variables back for linux_license and fix the ex…
28ef66b 
…cluded files (flutter/engine#49775)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 12, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 418c9e918a22 to b8e5d4776908 (7 revisions) (#…
4721f96 
…141489)

flutter/engine@418c9e9...b8e5d47

2024-01-12 jonahwilliams@google.com [Impeller] move TrackedObjectsVK to separate file. (flutter/engine#49773)
2024-01-12 54558023+keyonghan@users.noreply.github.com Add gclient_variables back for linux_license and fix the excluded files (flutter/engine#49775)
2024-01-12 jonahwilliams@google.com [Impeller] Descriptor pool incremental allocation. (flutter/engine#49686)
2024-01-12 zanderso@users.noreply.github.com Relands: Refactors RBE support (flutter/engine#49660)
2024-01-12 jonahwilliams@google.com [Impeller] finish migration to new render pass API. (flutter/engine#49740)
2024-01-12 jonahwilliams@google.com [Impeller] remove Buffer type and associated abstractions. (flutter/engine#49702)
2024-01-12 54558023+keyonghan@users.noreply.github.com Remove `gclient_variables` from `linux_license.json` (flutter/engine#49766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@keyonghan keyonghan mentioned this pull request Jan 16, 2024
Closed
@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Jan 17, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jan 17, 2024

Time to revert pull request flutter/engine/49775 has elapsed.
You need to open the revert manually and process as a regular pull request.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jan 17, 2024
@zanderso zanderso mentioned this pull request Jan 17, 2024
Merged
auto-submit bot pushed a commit that referenced this pull request Jan 17, 2024
@zanderso
Revert "Add gclient_variables back for linux_license and fix the excl…
60ce382 
…uded files" (#49817)

Reverts #49775

The autorollers create PRs with this flag set to true (the default). This breaks the license check on autoroller PRs since the autorollers are trying to add back the entries in the excluded files list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux license starts failing when "download_android_deps": false is applied
4 participants
@keyonghan @johnmccutchan @zanderso @godofredoc