Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gclient_variables from linux_license.json #49766

Merged

Conversation

keyonghan
Copy link
Contributor

The gclient_variables has never been used and this is to unblock a recipes CL: https://flutter-review.googlesource.com/c/recipes/+/53902

Part of flutter/flutter#141461

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 12, 2024
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit d437533 into flutter:main Jan 12, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 12, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 12, 2024
…141489)

flutter/engine@418c9e9...b8e5d47

2024-01-12 jonahwilliams@google.com [Impeller] move TrackedObjectsVK to separate file. (flutter/engine#49773)
2024-01-12 54558023+keyonghan@users.noreply.github.com Add gclient_variables back for linux_license and fix the excluded files (flutter/engine#49775)
2024-01-12 jonahwilliams@google.com [Impeller] Descriptor pool incremental allocation. (flutter/engine#49686)
2024-01-12 zanderso@users.noreply.github.com Relands: Refactors RBE support (flutter/engine#49660)
2024-01-12 jonahwilliams@google.com [Impeller] finish migration to new render pass API. (flutter/engine#49740)
2024-01-12 jonahwilliams@google.com [Impeller] remove Buffer type and associated abstractions. (flutter/engine#49702)
2024-01-12 54558023+keyonghan@users.noreply.github.com Remove `gclient_variables` from `linux_license.json` (flutter/engine#49766)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants