Revert "Add gclient_variables back for linux_license and fix the excluded files" #49817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 17, 2024
…x the excluded files" (flutter/engine#49817)
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 17, 2024
…ions) (#141667) Manual roll requested by zra@google.com Cannot build log URL because revision "73a2de5da53f" is invalid: Luci builds of "Mac builder_cache" for 73a2de5da53f8ab133e88b43d05189879c370cb3 was INFRA_FAILURE 2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Encode directly to command buffer for Vulkan." (flutter/engine#49818) 2024-01-17 zanderso@users.noreply.github.com Revert "Add gclient_variables back for linux_license and fix the excluded files" (flutter/engine#49817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #49775
The autorollers create PRs with this flag set to true (the default). This breaks the license check on autoroller PRs since the autorollers are trying to add back the entries in the excluded files list.