Add a basic CONTRIBUTING.md #1

abarth · 2015-07-16T19:26:15Z

No description provided.

eseidelGoogle · 2015-07-16T19:30:29Z

CONTRIBUTING.md

+    "managed": False,
+    "name": "src",
+    "url": "git@github.com:<your_name_here>/sky_engine.git",
+    "custom_deps": {},


Is this needed?

eseidelGoogle · 2015-07-16T19:31:28Z

lgtm

Add a basic CONTRIBUTING.md

collinjackson · 2015-07-16T19:36:12Z

CONTRIBUTING.md

+Building the code
+-----------------
+
+ 1. `./mojo/tools/mojob gn`


should be mojob.py

1. We would assert if you tried to start an animation from within an animation status callback. This is a common pattern, so I fixed this assert (in Ticker._tick). 2. We would assert for animations with duration under a millisecond. Fixed. Also removed the workarounds assocated with #1.

Merge pull request from flutter/engine

https://dart.googlesource.com/sdk.git/+log/6aa7407d6309..e84bea25df23 git log 6aa7407..e84bea2 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 jensj@google.com [CFE] Fix crash in incremental compiler caused by async redirecting factory 2020-01-23 jensj@google.com [CFE] Incremental compiler refactor #1 2020-01-23 athom@google.com [release] Prepare CHANGELOG for 2.7.1 2020-01-23 sstrickl@google.com [vm] Refactor debug info handling code into a new package. 2020-01-23 jensj@google.com [CFE] Strong test can have linked dependencies 2020-01-23 johnniwinther@google.com [cfe] Check null nullable accesses and include null in inferred type for null aware expressions Created with: gclient setdep -r src/third_party/dart@e84bea25df23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: dart-vm-team@google.com

Roll Dart version e24733e...63cf56d dart-lang/sdk@e24733ebd1 [ VM ] Change version output message to reference SDK instead of VM dart-lang/sdk@bb8d145616 Revert "[SDK] Adds an SDK hash to kernels and the VM." dart-lang/sdk@a558d576b7 Use ///-style doc comments in analyzer/tool dart-lang/sdk@c68fd58513 Use ///-style doc comments in analyzer/test dart-lang/sdk@48608ce9bc Migrate language_2/variance to NNBD. dart-lang/sdk@d4154ac6dc Migrate language_2/unsorted to NNBD. dart-lang/sdk@1ab82dee7e Migrate language_2/nonfunction_type_aliases to NNBD. dart-lang/sdk@648b5e9c68 Use ///-style doc comments in analyzer/lib dart-lang/sdk@04dd5edc6a update fixnum to nnbd version dart-lang/sdk@baa5717f78 Use ///-style doc comments in analyzer/lib/src/generated dart-lang/sdk@411c9cc992 [Test] Skips sdk_hash_test for incompatible setups. dart-lang/sdk@a89b7a4ef7 Use ///-style doc comments in analyzer/lib/src/dart dart-lang/sdk@66c1b51c07 [dart2js] 20 dart2js tests ported to nnbd flutter#1. dart-lang/sdk@f4b19b8c2a [dart2js] Support package json files in modular_test_suite. dart-lang/sdk@1a278118dd [Test] Fixes sdk_hash_test broken by Windows line breaks. dart-lang/sdk@edde575dcd [SDK] Adds an SDK hash to kernels and the VM. dart-lang/sdk@d5120208b4 [cfe] Update CFE message to use 'null safety' instead of 'non-nullable' dart-lang/sdk@da39a4abff [vm/ffi] Remove try-catch from ffi trampoline if no handle scope dart-lang/sdk@15464a462f Add internal benchmarks to .gitignore. dart-lang/sdk@99144ed84d [infra] Remove support for approvals from compare_results dart-lang/sdk@98324c95d5 Roll benchmarks-internal to 15a6634bd60ed0b937ed5dbc874cba2da9865514 dart-lang/sdk@53807c1d79 [vm] Remove ARMv6 related code dart-lang/sdk@85d37c1ede [co19] Enable Language/Libraries_and_Scripts tests dart-lang/sdk@bcd2708843 [co19] Roll co19 to e674d8ccb29250fa5d7ac886fa98c5962543fffc dart-lang/sdk@b4b44d6b4b Revert "[CFE] Set correct async markers in outline phase" dart-lang/sdk@718df630ea [infra] Support posting results to staging in post_results_to_pubsub

…visions) (#43457)" (#43466) This reverts commit a109e0b as it breaks flutter framework tests during subsequent roll. From flutter/flutter#130138: _TypeError: (#0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53)) ``` #0 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:450:53) #1 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #2 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:444:23) #3 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #4 _ProgramInfoBuilder.createInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:419:54) #5 _ProgramInfoBuilder.getInfoNodeFor (package:vm_snapshot_analysis/v8_profile.dart:374:14) #6 ListIterable.forEach (dart:_internal/iterable.dart:39:13) #7 _ProgramInfoBuilder.build (package:vm_snapshot_analysis/v8_profile.dart:338:16) #8 toProgramInfo (package:vm_snapshot_analysis/v8_profile.dart:282:8) #9 _treemapFromSnapshot (package:vm_snapshot_analysis/treemap.dart:158:27) #10 treemapFromJson (package:vm_snapshot_analysis/treemap.dart:85:5) #11 SizeAnalyzer.analyzeZipSizeAndAotSnapshot (package:flutter_tools/src/base/analyze_size.dart:123:59) #12 AndroidGradleBuilder._performCodeSizeAnalysis (package:flutter_tools/src/android/gradle.dart:623:60) #13 AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:604:15) <asynchronous suspension> #14 AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:242:5) <asynchronous suspension> #15 BuildApkCommand.runCommand (package:flutter_tools/src/commands/build_apk.dart:116:5) <asynchronous suspension> #16 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1297:27) <asynchronous suspension> #17 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19) <asynchronous suspension> #18 CommandRunner.runCommand (package:args/command_runner.dart:212:13) <asynchronous suspension> ```

The culprit test asks different threads to access some stack variables, but the stack might return earlier than the threads' completion. This PR fixes it by adding latches. This test, despite being possibly fine for now, consistently triggers the following asan error when I make some unrelated trivial changes. The thrown error: <details> <pre> [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from EmbedderTest [ RUN ] EmbedderTest.EmbedderThreadHostUseCustomThreadConfig ================================================================= ==14398==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00031833b530 at pc 0x00013248d543 bp 0x000318740390 sp 0x00031873fb58 WRITE of size 4 at 0x00031833b530 thread T2 #0 0x13248d542 in pthread_getschedparam+0x3d2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542) #1 0x100577671 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0::operator()() const+0x1a1 (embedder_unittests:x86_64+0x10030b671) #2 0x1005774a2 in decltype(std::declval<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>()()) std::_fl::__invoke[abi:v15000]<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b4a2) #3 0x100577402 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&>(flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0&)+0x22 (embedder_unittests:x86_64+0x10030b402) #4 0x1005773ba in std::_fl::__function::__alloc_func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x10030b3ba) #5 0x1005734f6 in std::_fl::__function::__func<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0, std::_fl::allocator<flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x1003074f6) #6 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525) #7 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2) #8 0x100c229dc in fml::MessageLoopImpl::FlushTasks(fml::FlushType)+0x37c (embedder_unittests:x86_64+0x1009b69dc) #9 0x100c22577 in fml::MessageLoopImpl::RunExpiredTasksNow()+0x27 (embedder_unittests:x86_64+0x1009b6577) #10 0x100c8aa2f in fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)+0x2f (embedder_unittests:x86_64+0x100a1ea2f) #11 0x7ff817b54508 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__+0x13 (CoreFoundation:x86_64+0x97508) #12 0x7ff817b540b8 in __CFRunLoopDoTimer+0x310 (CoreFoundation:x86_64+0x970b8) #13 0x7ff817b53ce9 in __CFRunLoopDoTimers+0x11c (CoreFoundation:x86_64+0x96ce9) #14 0x7ff817b380ac in __CFRunLoopRun+0x83b (CoreFoundation:x86_64+0x7b0ac) #15 0x7ff817b372a8 in CFRunLoopRunSpecific+0x22c (CoreFoundation:x86_64+0x7a2a8) #16 0x100c8b155 in fml::MessageLoopDarwin::Run()+0x305 (embedder_unittests:x86_64+0x100a1f155) #17 0x100c223d0 in fml::MessageLoopImpl::DoRun()+0x150 (embedder_unittests:x86_64+0x1009b63d0) #18 0x100c1f1fa in fml::MessageLoop::Run()+0x2a (embedder_unittests:x86_64+0x1009b31fa) #19 0x100c7baa4 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0::operator()() const+0x194 (embedder_unittests:x86_64+0x100a0faa4) #20 0x100c7b8e2 in decltype(std::declval<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>()()) std::_fl::__invoke[abi:v15000]<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f8e2) #21 0x100c7b842 in void std::_fl::__invoke_void_return_wrapper<void, true>::__call<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&)+0x22 (embedder_unittests:x86_64+0x100a0f842) #22 0x100c7b7fa in std::_fl::__function::__alloc_func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()[abi:v15000]()+0x2a (embedder_unittests:x86_64+0x100a0f7fa) #23 0x100c77ad6 in std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+0x26 (embedder_unittests:x86_64+0x100a0bad6) #24 0x10066a525 in std::_fl::__function::__value_func<void ()>::operator()[abi:v15000]() const+0x105 (embedder_unittests:x86_64+0x1003fe525) #25 0x10066a3f2 in std::_fl::function<void ()>::operator()() const+0x22 (embedder_unittests:x86_64+0x1003fe3f2) #26 0x100c75388 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::operator()(void*) const+0xe8 (embedder_unittests:x86_64+0x100a09388) #27 0x100c75227 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+0xc7 (embedder_unittests:x86_64+0x100a09227) #28 0x1324b3e76 in asan_thread_start(void*)+0x46 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x52e76) #29 0x7ff817a5c18a in _pthread_start+0x62 (libsystem_pthread.dylib:x86_64+0x618a) #30 0x7ff817a57ae2 in thread_start+0xe (libsystem_pthread.dylib:x86_64+0x1ae2) Address 0x00031833b530 is located in stack of thread T0 at offset 144 in frame #0 0x1002d051f in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0xf (embedder_unittests:x86_64+0x10006451f) This frame has 12 object(s): [32, 40) 'thread_host' (line 3445) [64, 112) 'ref.tmp' (line 3446) [144, 148) 'ui_policy' (line 3449) <== Memory access at offset 144 is inside this variable [160, 168) 'ui_param' (line 3450) [192, 200) 'ref.tmp2' (line 3452) [224, 272) 'ref.tmp5' (line 3452) [304, 320) 'agg.tmp' [336, 340) 'io_policy' (line 3458) [352, 360) 'io_param' (line 3459) [384, 392) 'ref.tmp6' (line 3460) [416, 464) 'ref.tmp10' (line 3460) [496, 512) 'agg.tmp11' HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-use-after-scope (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x2c542) in pthread_getschedparam+0x3d2 Shadow bytes around the buggy address: 0x00031833b280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x00031833b300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x00031833b380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x00031833b400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x00031833b480: 00 00 00 00 f1 f1 f1 f1 00 f2 f2 f2 f8 f8 f8 f8 =>0x00031833b500: f8 f8 f2 f2 f2 f2[f8]f2 f8 f2 f2 f2 f8 f2 f2 f2 0x00031833b580: f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 00 00 f2 f2 f8 f2 0x00031833b600: f8 f2 f2 f2 f8 f2 f2 f2 f8 f8 f8 f8 f8 f8 f2 f2 0x00031833b680: f2 f2 00 00 f3 f3 f3 f3 00 00 00 00 00 00 00 00 0x00031833b700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x00031833b780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Thread T2 created by T0 here: #0 0x1324ae92d in pthread_create+0x5d (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x4d92d) #1 0x100c73901 in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x401 (embedder_unittests:x86_64+0x100a07901) #2 0x100c73cca in fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)+0x2a (embedder_unittests:x86_64+0x100a07cca) #3 0x100c748c9 in std::_fl::__unique_if<fml::ThreadHandle>::__unique_single std::_fl::make_unique[abi:v15000]<fml::ThreadHandle, fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>(fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0&&)+0x149 (embedder_unittests:x86_64+0x100a088c9) #4 0x100c74335 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x255 (embedder_unittests:x86_64+0x100a08335) #5 0x100c746b2 in fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)+0x32 (embedder_unittests:x86_64+0x100a086b2) #6 0x106ee0b1a in std::_fl::__unique_if<fml::Thread>::__unique_single std::_fl::make_unique[abi:v15000]<fml::Thread, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&>(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig&)+0x4a (embedder_unittests:x86_64+0x106c74b1a) #7 0x106ee08e8 in flutter::ThreadHost::CreateThread(flutter::ThreadHost::Type, std::_fl::optional<fml::Thread::ThreadConfig>, flutter::ThreadHost::ThreadHostConfig const&) const+0x1b8 (embedder_unittests:x86_64+0x106c748e8) #8 0x106ee1466 in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2f6 (embedder_unittests:x86_64+0x106c75466) #9 0x106ee19ca in flutter::ThreadHost::ThreadHost(flutter::ThreadHost::ThreadHostConfig const&)+0x2a (embedder_unittests:x86_64+0x106c759ca) #10 0x100b6f730 in flutter::EmbedderThreadHost::CreateEngineManagedThreadHost(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0x3a0 (embedder_unittests:x86_64+0x100903730) #11 0x100b6e51c in flutter::EmbedderThreadHost::CreateEmbedderOrEngineManagedThreadHost(FlutterCustomTaskRunners const*, std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&)+0xcc (embedder_unittests:x86_64+0x10090251c) #12 0x1002d0748 in flutter::testing::EmbedderTest_EmbedderThreadHostUseCustomThreadConfig_Test::TestBody()+0x238 (embedder_unittests:x86_64+0x100064748) #13 0x1089ce93b in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10876293b) #14 0x108955bdf in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)+0x2cf (embedder_unittests:x86_64+0x1086e9bdf) #15 0x108955755 in testing::Test::Run()+0x3a5 (embedder_unittests:x86_64+0x1086e9755) #16 0x108957b23 in testing::TestInfo::Run()+0x593 (embedder_unittests:x86_64+0x1086ebb23) #17 0x10895a8f2 in testing::TestSuite::Run()+0x6e2 (embedder_unittests:x86_64+0x1086ee8f2) #18 0x108977d7a in testing::internal::UnitTestImpl::RunAllTests()+0xb9a (embedder_unittests:x86_64+0x10870bd7a) #19 0x1089ee88b in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x21b (embedder_unittests:x86_64+0x10878288b) #20 0x1089770ac in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)+0x2cc (embedder_unittests:x86_64+0x10870b0ac) #21 0x108976c3b in testing::UnitTest::Run()+0x28b (embedder_unittests:x86_64+0x10870ac3b) #22 0x1083e45e2 in RUN_ALL_TESTS()+0x22 (embedder_unittests:x86_64+0x1081785e2) #23 0x1083e43c8 in main+0x6e8 (embedder_unittests:x86_64+0x1081783c8) #24 0x213ff0365 (<unknown module>) ==14398==ABORTING [1] 14398 abort ../out/host_debug_unopt/embedder_unittests </pre> </details> The changes I made (isolated from a larger change, therefore it doesn't seem reasonable by itself): ```diff // shell/common/platform_view.cc, L33 void PlatformView::DispatchPointerDataPacket( std::unique_ptr<PointerDataPacket> packet) { - delegate_.OnPlatformViewDispatchPointerDataPacket( - pointer_data_packet_converter_.Convert(std::move(packet))); + delegate_.OnPlatformViewDispatchPointerDataPacket(std::move(packet)); } ``` Base engine rev: de2a73c Environment: Macbook with M1 Max Chip, OS 14.4.1 Compiling with: ``` ./engine/src/flutter/tools/gn --goma --unoptimized --asan --xcode-symlinks ./depot_tools/ninja -j200 -C ./engine/src/out/host_debug_unopt ./out/host_debug_unopt/embedder_unittests ``` [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

https://skia.googlesource.com/skia.git/+log/d55406ca32e9..0d8d9d2974fa 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 03b32d20940d to d90557b380fa (4 revisions) 2024-08-28 jlavrova@google.com Split FreeType & FontConfig, step #1 2024-08-28 danieldilan@google.com Reland "GPU support for F16F16F16x SkColorType." 2024-08-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fb93bdd85957 to 8b35b106dd98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/0d8d9d2974fa..e37b6b198016 2024-08-28 jlavrova@google.com Revert "Split FreeType & FontConfig, step #1" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,egdaniel@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/2d5a75027691..5515c08c2e44 2024-09-03 beaufort.francois@gmail.com [webgpu-headers] Add macro for dropping "descriptor" 2024-09-03 jlavrova@google.com Reland "Split FreeType & FontConfig, step #1" 2024-09-03 lukasza@chromium.org [rust png] Minimal `onGetFrameInfo` to support non-animated images. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/5515c08c2e44..0d9333e72a39 2024-09-03 robertphillips@google.com [graphite] Add centralized app flag handling 2024-09-03 nicolettep@google.com Indicate we are able to root on Pixel5 devices 2024-09-03 jvanverth@google.com [graphite] Make circular_rrect_clip snippet output coverage instead. 2024-09-03 jvanverth@google.com [graphite] Rename clip shader block to be more generic. 2024-09-03 jlavrova@google.com Revert "Reland "Split FreeType & FontConfig, step #1"" 2024-09-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from aa237b66d8cc to 5e29f5c97fc4 (1 revision) 2024-09-03 ccameron@chromium.org SkAndroidCodec: Add getAndroidGainmap that populates an SkAndroidCodec 2024-09-03 kjlubick@google.com Apply some clang-tidy suggestions to graphite code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,codefu@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/9d16a74c860a..ca94a5369af5 2024-09-19 jlavrova@google.com Reland "Reland "Split FreeType & FontConfig, step #1"" 2024-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e80717cdb17e to e4d224c16ab4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,chinmaygarde@google.com,jmbetancourt@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eseidelGoogle reviewed Jul 16, 2015
View reviewed changes

abarth force-pushed the contributing_md branch from 2007713 to 67cbc46 Compare July 16, 2015 19:31

Add a basic CONTRIBUTING.md

d974d65

abarth force-pushed the contributing_md branch from 67cbc46 to d974d65 Compare July 16, 2015 19:32

abarth added a commit that referenced this pull request Jul 16, 2015

Merge pull request #1 from abarth/contributing_md

51b9fa4

Add a basic CONTRIBUTING.md

abarth merged commit 51b9fa4 into flutter:master Jul 16, 2015

collinjackson reviewed Jul 16, 2015
View reviewed changes

CONTRIBUTING.md

Building the code

-----------------

1. `./mojo/tools/mojob gn`

Copy link

Contributor

collinjackson Jul 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be mojob.py

abarth deleted the contributing_md branch July 16, 2015 19:40

mpcomplete mentioned this pull request Aug 13, 2015

Fix common asserts in animation API. #592

Merged

jamesr mentioned this pull request Feb 24, 2017

Update to Dart revision de63e4fa94a1cebf86f0541ac14f25fd0bff73c0 #3442

Merged

krisgiesing mentioned this pull request Jul 13, 2017

[fuchsia] Make it easy to flip the whole system between flutter_jit_a… #3873

Merged

rmistry mentioned this pull request Apr 10, 2018

Roll src/third_party/skia/ 52e16d984..ded7a5586 (1 commit) #4959

Closed

terrylucas mentioned this pull request Jun 6, 2019

Revert "Use track-widget-creation transformer included in the sdk. (#9085)" #9134

Merged

jason-simmons mentioned this pull request Sep 18, 2019

Check for index bounds in RTL handling for trailing whitespace runs. #12336

Merged

j4qfrost pushed a commit to j4qfrost/engine that referenced this pull request Jan 11, 2020

Merge pull request flutter#1 from flutter/master

5302cf8

Merge pull request from flutter/engine

This was referenced Jan 23, 2020

Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) #15932

Closed

Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) #15933

Closed

Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) #15934

Merged

arbreng mentioned this pull request Mar 10, 2020

[Fuchsia] Move physical shape layer compositing to Flutter #17005

Merged

flar mentioned this pull request Jun 22, 2020

Enhance image_filter_layer caching to filter a cached child #17175

Merged

This was referenced Jun 26, 2020

Roll Dart SDK from 63cf56d92510 to 66c1b51c07b7 (14 revisions) #19332

Closed

Roll Dart SDK from 63cf56d92510 to 648b5e9c6860 (19 revisions) #19334

Closed

a-siva mentioned this pull request Jun 26, 2020

Manual roll of Dart e24733ebd1...63cf56d925 #19337

Merged

moffatman added a commit to moffatman/engine that referenced this pull request Oct 20, 2021

Attempt flutter#1 to fix CI failures

167f9f1

moffatman added a commit to moffatman/engine that referenced this pull request Nov 7, 2021

Attempt flutter#1 to fix CI failures

aebc548

moffatman added a commit to moffatman/engine that referenced this pull request Nov 9, 2021

Attempt flutter#1 to fix CI failures

2d85a53

moffatman added a commit to moffatman/engine that referenced this pull request Nov 30, 2021

Attempt flutter#1 to fix CI failures

6e49bad

moffatman added a commit to moffatman/engine that referenced this pull request Dec 9, 2021

Attempt flutter#1 to fix CI failures

7d7fe49

arbreng mentioned this pull request Dec 28, 2021

Vulkan support in the Embedder API #29391

Merged

arbreng mentioned this pull request Jan 13, 2022

[fuchsia] Update Vulkan header version to 1.2.198. #30770

Merged

Renzo-Olivares mentioned this pull request Jan 28, 2022

TextEditingDelta Support for the Web #28527

Merged

8 tasks

tianshaojie mentioned this pull request Mar 27, 2022

Merge pull request #1 from flutter/main #32277

Closed

8 tasks

everskies mentioned this pull request Mar 28, 2022

Fixing bug when ListenableEditingState is provided initialState with a valid composing range, android.view.inputmethod.BaseInputConnection.setComposingRegion(int, int) has NPE #30916

Merged

8 tasks

joshualitt mentioned this pull request Apr 5, 2022

[web] Migrate Flutter Web to JS static interop - 2. #32427

Merged

flar mentioned this pull request Jun 8, 2022

[Impeller] Add backdrop filter support; refactor EntityPass #33887

Merged

flar mentioned this pull request Feb 28, 2023

add DlCanvas(SkCanvas) vs DlCanvas(Builder) variants to DL rendertests #39944

Merged

knopp mentioned this pull request Jun 5, 2023

Fix clang tidy error and crash #42564

Merged

8 tasks

chunhtai mentioned this pull request May 30, 2024

Add support for setting the heading level for web semantics (#97894) #41435

Merged

8 tasks

This was referenced Aug 28, 2024

Roll Skia from d55406ca32e9 to f5f3648c25ec (3 revisions) #54849

Closed

Roll Skia from d55406ca32e9 to 0d8d9d2974fa (4 revisions) #54850

Merged

skia-flutter-autoroll mentioned this pull request Aug 28, 2024

Roll Skia from 0d8d9d2974fa to e37b6b198016 (1 revision) #54854

Merged

skia-flutter-autoroll mentioned this pull request Sep 3, 2024

Roll Skia from 2d5a75027691 to 5515c08c2e44 (3 revisions) #54941

Merged

This was referenced Sep 3, 2024

Roll Skia from 5515c08c2e44 to 43b4f389bab1 (5 revisions) #54943

Closed

Roll Skia from 5515c08c2e44 to 0d9333e72a39 (8 revisions) #54944

Merged

skia-flutter-autoroll mentioned this pull request Sep 19, 2024

Roll Skia from 9d16a74c860a to ca94a5369af5 (2 revisions) #55302

Merged

brandon-bethke-timu added a commit to timu-com/engine that referenced this pull request Oct 4, 2024

skia flutter#1

558680d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a basic CONTRIBUTING.md #1

Add a basic CONTRIBUTING.md #1

abarth commented Jul 16, 2015

eseidelGoogle Jul 16, 2015

eseidelGoogle commented Jul 16, 2015

collinjackson Jul 16, 2015

Add a basic CONTRIBUTING.md #1

Add a basic CONTRIBUTING.md #1

Conversation

abarth commented Jul 16, 2015

eseidelGoogle Jul 16, 2015

Choose a reason for hiding this comment

eseidelGoogle commented Jul 16, 2015

collinjackson Jul 16, 2015

Choose a reason for hiding this comment