Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Update Vulkan header version to 1.2.198. #30770

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

gnoliyil
Copy link
Contributor

This updates the downstream Vulkan header for Fuchsia
to 1.2.198 so that it could support the upstream
FUCHSIA buffer collection extension.

TEST: build and no-op on Fuchsia
Bug: flutter/flutter#96312

@gnoliyil
Copy link
Contributor Author

@arbreng @akbiggs PTAL.

Copy link
Contributor

@arbreng arbreng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a few things to do before landing

  1. Update licenses_third_party to fix the check
  2. Wait for a successful Fuchsia SDK roll
  3. Verify this works on smart_display -- does smart_display use a Fuchsia image / vulkan ICD that is compatible with the new headers?

@arbreng
Copy link
Contributor

arbreng commented Jan 13, 2022

Fuchsia SDK has rolled, so now only #1 and #3 need to be done

@chinmaygarde
Copy link
Member

The licenses need to be updated. The diff is at the bottom of the logs here. You should just be able to apply the patch yourself instead of having to run the script again.

@gnoliyil
Copy link
Contributor Author

LGTM but a few things to do before landing

  1. Update licenses_third_party to fix the check
  2. Wait for a successful Fuchsia SDK roll
  3. Verify this works on smart_display -- does smart_display use a Fuchsia image / vulkan ICD that is compatible with the new headers?

All done. Fuchsia image / SDK in g3 has been updated so that they are already using the ICD and loader compatible with the new headers.

This updates the downstream Vulkan header for Fuchsia
to 1.2.198 so that it could support the upstream
FUCHSIA buffer collection extension.

TEST: build and no-op on Fuchsia
@akbiggs akbiggs merged commit 7a33b4b into flutter:main Jan 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 18, 2022
godofredoc pushed a commit to flutter/flutter that referenced this pull request Jan 19, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906)

* 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890)

* 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907)

* 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908)

* ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910)

* 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906)

* 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890)

* 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907)

* 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908)

* ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910)

* 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants