add DlCanvas(SkCanvas) vs DlCanvas(Builder) variants to DL rendertests #39944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
force-pushed
the
DLrendertests-on-DlCanvas
branch
from
b079569
to
55feaae
Compare
chinmaygarde
approved these changes
Mar 1, 2023
| static const CvSetup kEmptyCvSetup = [](SkCanvas*, SkPaint&) {}; | ||
| static const CvRenderer kEmptyCvRenderer = [](SkCanvas*, const SkPaint&) {}; | ||
| static const DlRenderer kEmptyDlRenderer = [](DisplayListBuilder&) {}; | ||
| typedef const std::function<void(SkCanvas*, SkPaint&)> SkSetup; |
There was a problem hiding this comment.
I realize this was just renaming existing stuff, but prefer using to typedef. It usually doesn't matter except you need to use using if you need template parameters. So its better (IMO) to be consistent and it seems to be the C++ way.
flar
force-pushed
the
DLrendertests-on-DlCanvas
branch
from
aee3de6
to
bb96142
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 1, 2023
chinmaygarde
pushed a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 3, 2023
…rations (flutter#39944) add DlCanvas(SkCanvas) vs DlCanvas(Builder) variants to DL rendertests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a note that this PR may have a slight negative impact on the "display list builder" benchmarks as it adds a couple of new op variants to the list of DL test snippets which are used to measure the builder performance.
This PR adds new testing variants to the display_list_rendertests test suite. Previously we tested that the following graphics flows produced the same results graphically:
DisplayListBuilder rendering, dispatched to an SkCanvas(replaced by # 6 below)SkCanvas rendering captured into a DL(no longer represents an active Flutter work-flow)# 2(now from # 6 below) that were recorded at 1x, rendered at 2xThe new rendering variations that are now added to the above are:
DL produced by # 4 identical to DL produced by # 6(# 4 no longer produces a DL so no pair of DL's to compare)Note that when all of the steps 1-7 were in place some bugs were discovered in
DlSkCanvasAdapternot synchronizing all attributes and the image variants ofDLOpnot doing precise comparisons.This PR is a draft because now that we are testing that all of the above agree with each other, some of the comparisons may be eliminated as obsolete. In particular, # 2 (replaced by # 6) and # 3. # 4's DL replaced by # 7's DL if # 2 is eliminated.(All adjustments to removing the old steps and replacing them with the new steps have been implemented so this PR is moving from draft status to ready for review.)