Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove shadowed wrapper #31

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChasNelson1990
Copy link
Member

@ChasNelson1990 ChasNelson1990 commented Oct 8, 2024

Description

This PR does 2 things:

  1. it merges all of the .wrapper CSS into one bit - wrappers should be identical across pages so I think this makes sense. This change definitely belongs here.
  2. it sets the .main background colour to primary10 (keeping the .homepage .hero as light. This requires a knock-on to make sure that sidebar modules have a background colour of light. I am not 100% sure if this change belongs here or in ZaRR - thoughts @A-Souhei?

relates (but is not dependent on) fjelltopp/ckanext-zarr#44

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@ChasNelson1990 ChasNelson1990 self-assigned this Oct 8, 2024
@ChasNelson1990 ChasNelson1990 deleted the feat-remove-shadowed-content-wrapper branch October 9, 2024 08:01
@ChasNelson1990 ChasNelson1990 restored the feat-remove-shadowed-content-wrapper branch October 9, 2024 10:04
@ChasNelson1990 ChasNelson1990 reopened this Oct 9, 2024
@ChasNelson1990
Copy link
Member Author

Not quite sure how this got closed?

@ChasNelson1990 ChasNelson1990 force-pushed the feat-remove-shadowed-content-wrapper branch from 49916c1 to 0b6b766 Compare October 9, 2024 10:04
@A-Souhei A-Souhei marked this pull request as draft October 10, 2024 14:11
Copy link
Contributor

@A-Souhei A-Souhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChasNelson1990 ,
With changing the background we will also need to change the dataset read page, or shall we just keep the dataset read page background white?
image
image

I want to think that in ZaRR it could be easier but I am not sure

@ChasNelson1990
Copy link
Member Author

Oh, yes, let's make the dataset read pages white.

image

Probably all things under the tabs should be white?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants