Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make group icons on homepage show their group images as icons #44

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

ChasNelson1990
Copy link
Member

Description

We wanted the icons on the homepage that show the different resource types to be more visual. I have given each group and image_url and that is now rendered inside the little box.

Also, I made the flag a little thinner.

The zarr-ckan PR includes updated demo data loader for these icons.

relates fjelltopp/zarr-ckan#
relates (but is not dependent on) fjelltopp/ckanext-fjelltopp-theme#31

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Contributor

@A-Souhei A-Souhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ChasNelson1990 ChasNelson1990 merged commit b65e604 into main Oct 8, 2024
2 checks passed
@ChasNelson1990 ChasNelson1990 deleted the feat-minor-ui-changes branch October 8, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants