Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove shadowed wrapper #31

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: remove shadowed wrapper #31

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35d672c
feat: remove shadowed wrapper
ChasNelson1990 Oct 8, 2024
0b6b766
fix: user border: none for consistency
ChasNelson1990 Oct 8, 2024
70bfeb8
Merge branch 'main' into feat-remove-shadowed-content-wrapper
A-Souhei Oct 10, 2024
ffbd761
Merge branch 'main' into feat-remove-shadowed-content-wrapper
A-Souhei Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 31 additions & 35 deletions ckanext/fjelltopp_theme/assets/css/fjelltopp-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,30 @@ body {
border-bottom: none;
}

.main, .homepage .hero {
.main {
min-height: 80vh;
padding-top: 32px;
padding-bottom: 64px;
background: config.$light;
background-color: config.$primary10;
}

.homepage .hero, .main.user-profile-page {
min-height: 80vh;
padding-top: 32px;
padding-bottom: 64px;
background: none;
background-color: config.$light;
}

/* modules */
aside.secondary .module {
background-color: config.$light;
margin: 0;
width: 100%;
padding: 12px;
border: config.$primary65 thin solid;
}
/* modules */

.homepage .main,
.homepage .hero,
Expand Down Expand Up @@ -668,6 +686,17 @@ footer.site-footer .data-hub-stats {
margin-bottom: 64px;
}

/* wrapper used on all pages */
.wrapper {
border: none;
box-shadow: none;
background-color: transparent;
}

.wrapper::before {
border: none;
}

/* group box (group page?) template update might be needed as well TODO */
.group-box {
background: config.$light;
Expand Down Expand Up @@ -2136,11 +2165,6 @@ a.thumbnail.active {
border-right: 0;
}

.user-profile-page .wrapper {
box-shadow: none;
border: 0;
}

.user-profile-page .page-header {
background-color: config.$light;
}
Expand Down Expand Up @@ -2310,11 +2334,6 @@ ol.breadcrumb {
}
}

.dataset.wrapper {
border: none;
box-shadow: none;
}

.dataset .secondary {
padding-left: 39px;
padding-right: 39px;
Expand Down Expand Up @@ -2429,12 +2448,6 @@ ol.breadcrumb {


/* search page */
div.main.search .wrapper {
border: 0;
box-shadow: none;
background-color: transparent;
}

#content {
padding-left: 30px;
padding-right: 30px;
Expand All @@ -2448,7 +2461,6 @@ div.main.group-read .group-read-packages,
{
min-height: 0;
padding-bottom: 0;
background-color: config.$primary10;

.row > .big-search-form {
padding-left: 0;
Expand Down Expand Up @@ -2516,16 +2528,6 @@ div.main.group-read .group-read-packages,
}

/* ported */
.wrapper {
border: 0;
box-shadow: none;
background-color: transparent;
}

.wrapper::before {
border: none;
}

.row > .big-search-form {
padding-left: 0;
padding-right: 0;
Expand Down Expand Up @@ -2844,12 +2846,6 @@ div.main.group-read .group-read-packages,
box-shadow: none;
}

.wrapper {
border: config.$primary25 1px solid;
box-shadow: 0 0 0 0.4px config.$primary25;

}

.organization-activity-stream .secondary, .group-activity-stream .secondary {
display: none;
}
Expand Down
Loading