Actors v5 Plan

[ZenGround0]

Meta

This issue is a proposal for planning actors v5, which is scheduled to hit mainnet sometime in early June, exact epoch tbd. Work to be done includes required consensus breaking upgrades and testing improvements, optional consensus breaking upgrades that will be included if finished by all implementations on mainnet, and optional specs-actors non-breaking improvements.

Please leave your feedback in the comments, particularly on things that you expected to see but are missing.

Changes

Upgrades

We can't ship v5 until all live implementations have the following:

• FIP 0013 -- aggregate Porep. Issues: Add b̶a̶t̶c̶h̶e̶d̶ aggregated SectorProveCommit endpoint #1257, ConfirmSectorProofsValid: batch VerifyDealsOnSectorProveCommit  #474 (PR Aggregate PoRep #1381)
• FIP 0008 -- batched Precommit. Issue Add batched SectorPreCommit (FIP-0008) #1241
• FIP 0012 -- verified client reuse Implement off-chain Window PoSt verification #1327 (PR feat: Allow VerifiedClient DataCap to be topped up #1390)
• FIP 0011 -- consensus fault simplification (PR feat: Use constant consensus fault reward #1389)
• market cron randomness offset bug fix Shore up Publish Storage Deals load balancing  #1435 (PR Modify randomness logic for PublishStorageDeals #1439)

Technical debt, optimizations, . We can ship v5 without these fixes but would like to do them now. I'm proposing all implementations work on these after the requirements and then we ship the intersection of all our change sets. They are roughly in order of difficulty and I plan to work on them in about this order

• Miner.CompactPartitions doesn't reschedule replaced CC sectors correctly #1332 fix compact partitions bug
• Miner Policy: Correct truncating division #1250 correct truncating division
• CheckBalanceInvariants loads state inconsistently across methods #1340 inconsistent state loading
• skip calculating hash if not check, or remove param #1364 multisig optimization (PR compute the hash of the proposal iff the proposal hash is present #1365)
• Publish valid deals in PublishStorageDeals message #1375 more forgiving error handling for multi-deal publishing
• Simplify miner deadline state to rely on cron every epoch #992, Power.OnEpochTickEnd: preempt Miner queries to Power and Reward actors #799 cron cleanup and optimizations
• DealProposal's Label field serializes as non-UTF8 #1248 deal proposal serialization change

Conformance Testing

We won't ship v5 until specs-actors has the following

• specs-actors test-vector conformance tests and test-vector generation. Issues: Add gas accounting to scenario test VM #1266

specs-actors non-breaking changes

We will ship v5 without any of these. We will do as many of these as possible. They are in no particular order:

Logging

• Log burning events #1288, Add log messages for significant events #1060 logging

Simple cleanups

• Add a MustGet method to the adt.Array type #677 adt.Array:MustGet
• Paych voucher SecretPreimage name is backwards #1059 Fix Paych Voucher field name
• Miner: Simplify sector number allocation during precommit #905 sector number allocation cleanup
• Remove DomainSeparationTag_WindowedPoStDeadlineAssignment #1052 Remove unused DST
• Reorganize static functions to different files #1061 Reorganize static function files
• Follow-ons from accounting cleanup #1032, More tests of miner state fee accounting #966, Miner: Cleanup accounting methods #1006, Miner: VerifyPledgeRequirementsAndRepayDebts should return balance available after paying debt #1020 non-breaking accounting test and cleanup
• Introduce a PowerDelta (or just Delta?) struct #1011 power delta
• Add verified registry root address to singletons #1031 verifreg root becomes singleton

Testing & Validation

• Agent test anamolies #1387 fix agent tests
• Non disruptive CI for long running agent sims #1385 agent test CI
• More reward invariant testing #1284 reward actor invariant tests
• Validation speedup #1286 parallelize state validation checks
• Advanced sector commitment tests #936 more sector commitment tests
• Exercise all research team's "Filecoin Stories" as miner unit tests #991 research team's filecoin stories tests

[anorth]

I'm assuming #1241 batched pre-commit is excluded intentionally. I agree that porep aggregation needs to come first, but getting both in would probably remove the chain throughput limitation on the onboarding of new power.

I expected #277 terminating AWOL miners to be included.

A few others I'd consider including:

• Structure the interaction betwen windowPoSTs and deadlines such that a state root captures posted and missed sectors #1318
• Add return value to WithdrawBalance #1326

[nicola]

Hey @ZenGround0 fantastic update and very clear messaging, thank you!

[ZenGround0]

Added FIP 0008 per @anorth's feedback.

[rllola]

Hi,

I was wondering if you could clarify when to expect actors V4. This issue mention early June but Lotus 1.8 realease which should be release this wednesday mentioned support for actors V4.

filecoin-project/lotus#6084 (comment)

[jennijuju]

Hi,

I was wondering if you could clarify when to expect actors V4. This issue mention early June but Lotus 1.8 realease which should be release this wednesday mentioned support for actors V4.

filecoin-project/lotus#6084 (comment)

@rllola network v12 will upgrade the actor to v4, which is happening this Thursday 6 am UTC, more details can be found here.. The timeline of actor v5 is still working in prgress.

[ZenGround0]

Note, moving compact partitions bug fix from required for v5 to technical debt

[BigLep]

Items in this issue that didn't get completed are likely candidates for v6: #1458