Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Advanced sector commitment tests #936

Open
ZenGround0 opened this issue Aug 9, 2020 · 0 comments
Open

Advanced sector commitment tests #936

ZenGround0 opened this issue Aug 9, 2020 · 0 comments
Labels
testing Related to test coverage, quality, and tools

Comments

@ZenGround0
Copy link
Contributor

There are several sector commitment scenarios that still require testing. Most of these involve more complex interactions than are currently being tested, both between different areas of miner actor logic or across actors. Some of these are good candidates for the upcoming inter-actor scenario testing framework. These were partially gathered from an untracked TODO in TestCommitments

  1. Concurrent attempts to upgrade the same CC sector -- one upgrade attempt should succeed.
  2. Insufficient funds for prove commit -- gas is charged while reporting to power actor so need scenario testing
  3. Invalid seal proofs -- checked during power actor cron tick so need scenario testing
  4. CC sector targeted for upgrade expires naturally before the upgrade is proven
  5. Sufficient funds to cover pre commit of new sector but insufficient funds to cover the IP of CC sector we are upgrading from results in ErrInsufficientFunds (PCD is max of old sector IP and calculated PCD)
@anorth anorth added the testing Related to test coverage, quality, and tools label Aug 13, 2020
@ZenGround0 ZenGround0 added this to the 🧡 v3 milestone Oct 28, 2020
@anorth anorth removed this from the 🧡 v3 milestone Jan 19, 2021
@ZenGround0 ZenGround0 mentioned this issue Apr 8, 2021
28 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing Related to test coverage, quality, and tools
Projects
None yet
Development

No branches or pull requests

2 participants