Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Add b̶a̶t̶c̶h̶e̶d̶ aggregated SectorProveCommit endpoint #1257

Closed
anorth opened this issue Oct 18, 2020 · 1 comment · Fixed by #1381
Closed

Add b̶a̶t̶c̶h̶e̶d̶ aggregated SectorProveCommit endpoint #1257

anorth opened this issue Oct 18, 2020 · 1 comment · Fixed by #1381
Assignees
@ZenGround0
Labels
change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade fip Issue likely needs its own FIP P1 High priority, required for basic network functionality and growth scale Related to chain state or throughput scalability
Milestone
Network Hyperdrive

Comments

@anorth
Copy link
Member

anorth commented Oct 18, 2020

Sector prove-commits are already batched and processed at the end of each epoch via a cron call in the power actor. This might not be the best solution, though. It's complicated, can't reliably batch across epochs, and each ProveCommit invocation still mutates state etc.

It might be simpler and more effective to expose a ProveCommitBatch method, giving miners explicit control over batch size and direct exposure to the true gas cost.
@anorth anorth added discussion scale Related to chain state or throughput scalability change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade labels Oct 18, 2020
@ZenGround0 ZenGround0 added this to the 🧡 v3 milestone Oct 28, 2020
@ZenGround0 ZenGround0 added the fip Issue likely needs its own FIP label Oct 28, 2020
@anorth anorth removed this from the 🧡 v3 milestone Jan 19, 2021
@ZenGround0 ZenGround0 added this to the v4 milestone Mar 17, 2021
@ZenGround0
Copy link
Contributor

ZenGround0 commented Mar 17, 2021 •
edited
Loading

This has mutated into the very similar "Aggregated PoRep". Prototype PR #1381. FIP 0013

@ZenGround0 ZenGround0 added P1 High priority, required for basic network functionality and growth and removed discussion labels Mar 17, 2021
@ZenGround0 ZenGround0 mentioned this issue Apr 8, 2021
Closed
28 tasks
@momack2 momack2 mentioned this issue May 6, 2021
Closed
@BigLep BigLep modified the milestones: v6, v5 May 13, 2021
@BigLep BigLep linked a pull request May 13, 2021 that will close this issue
Aggregate PoRep #1381
Merged
10 tasks
@anorth anorth mentioned this issue May 14, 2021
Merged
@anorth anorth changed the title Add batched SectorProveCommit endpoint Add ~batched~ aggregated SectorProveCommit endpoint May 14, 2021
@anorth anorth changed the title Add ~batched~ aggregated SectorProveCommit endpoint Add b̵a̵t̵c̵h̵e̵d̵ aggregated SectorProveCommit endpoint May 14, 2021
@anorth anorth changed the title Add b̵a̵t̵c̵h̵e̵d̵ aggregated SectorProveCommit endpoint Add b̶a̶t̶c̶h̶e̶d̶ aggregated SectorProveCommit endpoint May 14, 2021
@anorth anorth mentioned this issue May 14, 2021
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZenGround0 ZenGround0

Labels
change-behaviour Changes behaviour or state interpretation, necessitating a network version upgrade fip Issue likely needs its own FIP P1 High priority, required for basic network functionality and growth scale Related to chain state or throughput scalability
Projects
None yet
Milestone
Network Hyperdrive
Development

Successfully merging a pull request may close this issue.

Aggregate PoRep filecoin-project/specs-actors
3 participants
@BigLep @anorth @ZenGround0