Restore testing #30
Closed
Restore testing #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patkivikram @marcosschroh - I assume the non-discovery of 1533 of the tests was by accident, not on purpose? I don't quite feel I know enough about aiokafka to fix all those failures. Some of them seem related to transaction support, which was something that was recently remade, right? So, eh, I'm leaving this one here as an unwelcome gift right before the weekend. Sorry! :-) |
forsberg
force-pushed
the
restore-tests
branch
2 times, most recently
from
76c83ae
to
908b2c3
Compare
A lot of test classes are named test_*, which makes pytest *not* find them by default
forsberg
force-pushed
the
restore-tests
branch
from
908b2c3
to
72c7437
Compare
|
We have to fix it urgently because it's a huge regression regarding original project. |
Merged
|
Because #141 was merged in, this can be closed. |
|
MAJOR THANKS @taybin !!! - Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of test classes are named test_*, which makes pytest not find them by default
Description
After the change in how tests are run, only 440 tests are found, instead of 1973 tests found when robinhood/faust runs their test suite.
Main reason for this is that a lot of the test classes are named
test_*and therefore are not automatically discovered by pytest.This PR restores discovery. Unfortunately a bunch of tests fails on the current codebase..