-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore testing #30
Restore testing #30
Conversation
@patkivikram @marcosschroh - I assume the non-discovery of 1533 of the tests was by accident, not on purpose? I don't quite feel I know enough about aiokafka to fix all those failures. Some of them seem related to transaction support, which was something that was recently remade, right? So, eh, I'm leaving this one here as an unwelcome gift right before the weekend. Sorry! :-) |
76c83ae
to
908b2c3
Compare
A lot of test classes are named test_*, which makes pytest *not* find them by default
908b2c3
to
72c7437
Compare
We have to fix it urgently because it's a huge regression regarding original project. |
Because #141 was merged in, this can be closed. |
MAJOR THANKS @taybin !!! - Closing this one. |
A lot of test classes are named test_*, which makes pytest not find them by default
Description
After the change in how tests are run, only 440 tests are found, instead of 1973 tests found when robinhood/faust runs their test suite.
Main reason for this is that a lot of the test classes are named
test_*
and therefore are not automatically discovered by pytest.This PR restores discovery. Unfortunately a bunch of tests fails on the current codebase..