Restore tests (updated) #141
Conversation
A lot of test classes are named test_*, which makes pytest *not* find them by default
* master: (75 commits) allow using 3.x of orjson. Use orjson in tests (#135) fix tests directory name in Makefile (#134) updating version on master updating changelog Close window after popping the value from store (#137) fix rocksdb for use with global tables or tables that use_partitioner (#130) updating version updating changelog Fix for #126 (#127) updating readme updating readme updating readme updating version adding changelog setting use partitioner to True (#122) #113 - fix datadog and statsd sensor - on_stream_event_out() can now be called with no state (#119) Add app_name to prometheus metrics (#120) updating version updating changelog fix scan options (#117) ...
|
It's failing because the code coverage is 59%, less than the 60% required. :/ |
|
@forsberg What is the purpose of the |
|
@taybin - the original faust project used class names that started with "test_" to the python_classes option was required for pytest to work. Later changes used the Test class names but until everything gets converted the python_classes is still needed. |
|
@bobh66 okay, thanks. There's only one test with the |
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 93.62% 93.62% -0.01%
==========================================
Files 100 100
Lines 10625 10627 +2
Branches 1201 1201
==========================================
+ Hits 9948 9949 +1
- Misses 618 619 +1
Partials 59 59
Continue to review full report at Codecov.
|
|
I'm not in a hurry to merge this as I'm working on restoring the aiokafka driver tests in #143 and I'm not fully getting some of the changes yet. |
Description
This is an updated version of #30, with master merged in.