Fix for canceled from mode #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinnichols101
approved these changes
Nov 20, 2020
forsberg
added a commit
to forsberg/faust-streaming
that referenced
this pull request
Nov 24, 2020
patkivikram
added a commit
that referenced
this pull request
May 6, 2021
* Restore testing A lot of test classes are named test_*, which makes pytest *not* find them by default * Fix failing unit test after fix for #42 * Restore tests by adding timeout arg * Restore original behaviour of _wait, don't always wait for signal_recovery_start * Restore a few of the aiokafka tests * Restore a few app tests * Run event path verification in aiokafka driver * lower minimum code coverage to 59% * reformat examples/livecheck.py with black * rename test class to match Test naming pattern * fix test__resume_streams, as assignment() returns a set Co-authored-by: Erik Forsberg <erik.forsberg@ferroamp.se> Co-authored-by: Erik Forsberg <forsberg@ferroamp.com> Co-authored-by: Vikram Patki <54442035+patkivikram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue in faust 678
This also fixes the issue where the consumer stops commuting offsets for a certain topic/partition