-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add richer data to the progress messages #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 8, 2022
TheCharlatan
force-pushed
the
dynamicProgress
branch
6 times, most recently
from
November 8, 2022 22:40
619defd
to
b027341
Compare
TheCharlatan
force-pushed
the
dynamicProgress
branch
2 times, most recently
from
November 9, 2022 08:17
9ca9674
to
908da54
Compare
h4sh3d
requested changes
Nov 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also rename the state names in this PR, either find better names or just more verbose than A B...
TheCharlatan
force-pushed
the
dynamicProgress
branch
3 times, most recently
from
November 14, 2022 22:14
71aedd4
to
7f4dae4
Compare
TheCharlatan
force-pushed
the
dynamicProgress
branch
from
November 29, 2022 13:26
6afb923
to
fe80137
Compare
TheCharlatan
force-pushed
the
dynamicProgress
branch
from
December 1, 2022 12:58
fe80137
to
32eeb09
Compare
h4sh3d
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of review, ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now three possible progress messages that a swap can issue. I message is just a string containing information. A transition goes from an old state to a new state. A state update updates the current state. Farcasterd only keeps the latest state update around, any previous state updates are discarded.
The progress now serves additional information about the confirmation status of various transactions during a swap. Additionally, it provides the block height of a running swap daemon.
I can be pretty flexible with the provided information here, so please let me know what additions / changes / re-designs you want.
Sample Output: