Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix swapd GetInfo / state should be serde #194

Closed
zkao opened this issue Nov 18, 2021 · 2 comments · Fixed by #761
Closed

fix swapd GetInfo / state should be serde #194

zkao opened this issue Nov 18, 2021 · 2 comments · Fixed by #761
Assignees
@h4sh3d
Labels
priority This should be prioritized

Comments

@zkao
Copy link
Member

zkao commented Nov 18, 2021

No description provided.

@zkao
Copy link
Member Author

zkao commented Nov 18, 2021

@h4sh3d,

could you make the State enum work for GetInfo to return the state to the swap-cli info $swapid command? it needs serde, i think

farcaster-node/src/swapd/runtime.rs

Line 1889 in 1189c49

// state: self.state, // FIXME serde missing

@zkao
Copy link
Member Author

zkao commented Nov 18, 2021

at the level of description we need to return to the terminal, the inner types are not needed, I guess, just the "wrapper" types

@h4sh3d h4sh3d self-assigned this Nov 19, 2021
@h4sh3d h4sh3d added the priority This should be prioritized label Nov 22, 2021
@h4sh3d h4sh3d mentioned this issue Dec 8, 2021
Closed
@zkao zkao mentioned this issue Jan 2, 2022
Closed
@TheCharlatan TheCharlatan linked a pull request Nov 9, 2022 that will close this issue
Add richer data to the progress messages #761
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4sh3d h4sh3d

Labels
priority This should be prioritized
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add richer data to the progress messages TheCharlatan/farcaster-node
2 participants
@h4sh3d @zkao