Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure swap progress messages flow #486

Closed
h4sh3d opened this issue Jun 10, 2022 · 0 comments · Fixed by #761
Closed

Ensure swap progress messages flow #486

h4sh3d opened this issue Jun 10, 2022 · 0 comments · Fixed by #761
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Jun 10, 2022

swapd can send to farcasterd a list of message to track progression of a swap. See e.g. #482 for more details.

We must ensure a Failure or Success message is sent at each end of swap protocol executions. If the swap executed successfully a Success must be returned, otherwise (refund, cancel, etc.) a Failure must be returned.

@TheCharlatan TheCharlatan added enhancement New feature or request good first issue Good for newcomers labels Jun 16, 2022
@TheCharlatan TheCharlatan self-assigned this Nov 7, 2022
@TheCharlatan TheCharlatan linked a pull request Nov 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants