Add else condition to prevent false positive #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downcase return value
Zeragamba
approved these changes
May 23, 2020
|
Looks good to me, but would like another to look. Not sure if there's another edge case here that someone else may know about. |
koic
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2005
Description:
As described in Issue #2005, the
Faker::Char.fix_umlautsmethod has a false positive when the string includes 'ss'. This PR adds an else clause so that the original match (downcased, like the other return values) is returned instead. This PR also adds an additional assertion to the test file to confirm that this false positive is accounted for.While working on this PR, I observed that this method may be limited in some ways surrounding casing. For example, you might want to replace
ÄwithAeorAE, but I thought that would very much complicate the method require several additional test cases and so I left it out for maybe another issue to be added.