Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker::Char.fix_umlauts remove non umlauts characters #2005

Closed
vitalinfo opened this issue May 21, 2020 · 2 comments
Closed

Faker::Char.fix_umlauts remove non umlauts characters #2005

vitalinfo opened this issue May 21, 2020 · 2 comments

Comments

@vitalinfo
Copy link

Faker::Char.fix_umlauts('classroom') returns "claroom", but should return as is

version 2.11.0
@jbergenson jbergenson mentioned this issue May 22, 2020
Merged
@jbergenson
Copy link
Contributor

Hey there, nice catch. I added a PR for this that should catch 'ss' and prevent it from being replaced with an empty string.

@Zeragamba
Copy link
Contributor

Resolved by #2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zeragamba @vitalinfo @jbergenson