Merge pull request #2012 from jbergenson/update-fix-umlauts

Add else condition to prevent false positive
faker-ruby · May 24, 2020 · 2c3664e · 2c3664e
2 parents 53341f8 + 34bbe72
commit 2c3664e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/helpers/char.rb b/lib/helpers/char.rb
@@ -15,6 +15,7 @@ def self.fix_umlauts(string)
         when 'ö' then 'oe'
         when 'ü' then 'ue'
         when 'ß' then 'ss'
+        else match.downcase
         end
       end
     end

diff --git a/test/faker/default/test_faker_char.rb b/test/faker/default/test_faker_char.rb
@@ -12,5 +12,7 @@ def test_fix_umlauts
     assert @tester.fix_umlauts('ö') == 'oe'
     assert @tester.fix_umlauts('ü') == 'ue'
     assert @tester.fix_umlauts('ß') == 'ss'
+    # tests false positive
+    assert @tester.fix_umlauts('ss') == 'ss'
   end
 end