Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz] Various smaller refactors #27368

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

sebmarkbage
Copy link
Collaborator

Back ported from a larger PR.

The compiled code ends with one.
The parent nodes are ReplayNodes and the terminal nodes are Resumable points.
@sebmarkbage sebmarkbage requested a review from acdlite September 13, 2023 03:48
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 13, 2023
@react-sizebot
Copy link

react-sizebot commented Sep 13, 2023

Comparing: 69be472...6c9271d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 166.38 kB 166.38 kB = 52.08 kB 52.08 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 175.64 kB 175.64 kB = 54.88 kB 54.88 kB
facebook-www/ReactDOM-prod.classic.js = 571.59 kB 571.59 kB = 100.62 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js = 555.37 kB 555.37 kB = 97.74 kB 97.74 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js +0.29% 155.75 kB 156.20 kB +0.16% 28.38 kB 28.42 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.29% 157.90 kB 158.35 kB +0.13% 29.33 kB 29.37 kB

Generated by 🚫 dangerJS against 6c9271d

@sebmarkbage sebmarkbage merged commit e520565 into facebook:main Sep 13, 2023
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
Back ported from a larger PR.

DiffTrain build for [e520565](e520565)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
Back ported from a larger PR.

DiffTrain build for commit e520565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants