[Fizz][Float] `<img>` inside `<picture>` should not preload during SSR #27346

gnoff · 2023-09-07T19:27:45Z

img tags inside picture tags should not automatically be preloaded because usually the img is a fallback. We will consider a more comprehensive way of preloading picture tags which may require a technique like using an inline script to construct the image in the browser but for now we simply omit the preloads to avoid harming load times by loading fallbacks.

…cause usually the img is a fallback. We will consider a more comprehensive way of preloading picture tags which may require a technique like using an inline script to construct the image in the browser but for now we simply omit the preloads to avoid harming load times by loading fallbacks.

react-sizebot · 2023-09-07T19:32:41Z

Comparing: 953cb02...7e553f4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	165.63 kB	165.63 kB	=	51.88 kB	51.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	174.70 kB	174.70 kB	=	54.61 kB	54.61 kB
facebook-www/ReactDOM-prod.classic.js	=	570.44 kB	570.44 kB	=	100.45 kB	100.45 kB
facebook-www/ReactDOM-prod.modern.js	=	554.21 kB	554.21 kB	=	97.61 kB	97.61 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7e553f4

#27346) img tags inside picture tags should not automatically be preloaded because usually the img is a fallback. We will consider a more comprehensive way of preloading picture tags which may require a technique like using an inline script to construct the image in the browser but for now we simply omit the preloads to avoid harming load times by loading fallbacks. DiffTrain build for [3566de5](3566de5)

facebook#27346) img tags inside picture tags should not automatically be preloaded because usually the img is a fallback. We will consider a more comprehensive way of preloading picture tags which may require a technique like using an inline script to construct the image in the browser but for now we simply omit the preloads to avoid harming load times by loading fallbacks.

#27346) img tags inside picture tags should not automatically be preloaded because usually the img is a fallback. We will consider a more comprehensive way of preloading picture tags which may require a technique like using an inline script to construct the image in the browser but for now we simply omit the preloads to avoid harming load times by loading fallbacks. DiffTrain build for commit 3566de5.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 7, 2023

consolidate tag scopes into a bitmask

7e553f4

gnoff requested a review from sebmarkbage September 7, 2023 19:42

sebmarkbage approved these changes Sep 7, 2023

View reviewed changes

gnoff merged commit 3566de5 into facebook:main Sep 7, 2023
35 of 36 checks passed

gnoff deleted the omit-preload-img-in-picture branch September 7, 2023 19:48

acdlite mentioned this pull request Sep 14, 2023

Update React from dd480ef92 to d6dcad6a8. vercel/next.js#55399

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fizz][Float] `<img>` inside `<picture>` should not preload during SSR #27346

[Fizz][Float] `<img>` inside `<picture>` should not preload during SSR #27346

gnoff commented Sep 7, 2023

react-sizebot commented Sep 7, 2023 •

edited

Loading

[Fizz][Float] <img> inside <picture> should not preload during SSR #27346

[Fizz][Float] <img> inside <picture> should not preload during SSR #27346

Conversation

gnoff commented Sep 7, 2023

react-sizebot commented Sep 7, 2023 • edited Loading

Critical size changes

Significant size changes

[Fizz][Float] `<img>` inside `<picture>` should not preload during SSR #27346

[Fizz][Float] `<img>` inside `<picture>` should not preload during SSR #27346

react-sizebot commented Sep 7, 2023 •

edited

Loading