Cleanup unused unstable_startTransition, unstable_useTransition, unstable_useDeferredValue exports from fb packages #27056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 035a41c...78b2829 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
acdlite
reviewed
Jul 5, 2023
packages/react/index.classic.fb.js
Outdated
| @@ -18,7 +18,6 @@ export { | |||
| StrictMode, | |||
| Suspense, | |||
| SuspenseList, | |||
| SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList | |||
There was a problem hiding this comment.
This one technically isn't stable yet, despite being used at Meta ("Stage 2.5"). If anything I'd remove the unprefixed one and keep the unstable one. You can move the alias to the wrapper module in Meta's repo.
There was a problem hiding this comment.
should the main React package be exporting this as unstable_SuspenseList as well then?
https://github.com/facebook/react/blob/main/packages/react/src/React.js#L133
There was a problem hiding this comment.
i'll follow up with a separate PR for SuspenseList changes – if i remove just the SuspenseList export here without other changes we get CI failures
acdlite
approved these changes
Jul 5, 2023
noahlemen
changed the title
noahlemen
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
…able_useDeferredValue exports from fb packages (#27056) ## Summary came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for [e91142d](e91142d)
noahlemen
added a commit
that referenced
this pull request
Jul 6, 2023
## Summary as we began [discussing yesterday](#27056 (comment)), `SuspenseList` is not actually stable yet, and should likely be exported with the `unstable_` prefix. the conversation yesterday began discussing this in the context of the fb-specific packages, but changing it there without updating everywhere else leads to test failures, so here the change is made across packages. ## How did you test this change? ``` yarn flow dom-browser yarn test ```
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Summary as we began [discussing yesterday](#27056 (comment)), `SuspenseList` is not actually stable yet, and should likely be exported with the `unstable_` prefix. the conversation yesterday began discussing this in the context of the fb-specific packages, but changing it there without updating everywhere else leads to test failures, so here the change is made across packages. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for [eb2c2f7](eb2c2f7)
styfle
added a commit
to vercel/next.js
that referenced
this pull request
Jul 13, 2023
### React upstream changes - facebook/react#27096 - facebook/react#27069 - facebook/react#27033 - facebook/react#27061 - facebook/react#27030 - facebook/react#27056
12 tasks
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
## Summary as we began [discussing yesterday](facebook/react#27056 (comment)), `SuspenseList` is not actually stable yet, and should likely be exported with the `unstable_` prefix. the conversation yesterday began discussing this in the context of the fb-specific packages, but changing it there without updating everywhere else leads to test failures, so here the change is made across packages. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for [eb2c2f7c2cf2652a168c2b433d2989131c69754b](facebook/react@eb2c2f7)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…able_useDeferredValue exports from fb packages (facebook#27056) ## Summary came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed. ## How did you test this change? ``` yarn flow dom-browser yarn test ```
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary as we began [discussing yesterday](facebook#27056 (comment)), `SuspenseList` is not actually stable yet, and should likely be exported with the `unstable_` prefix. the conversation yesterday began discussing this in the context of the fb-specific packages, but changing it there without updating everywhere else leads to test failures, so here the change is made across packages. ## How did you test this change? ``` yarn flow dom-browser yarn test ```
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
…able_useDeferredValue exports from fb packages (#27056) ## Summary came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed. ## How did you test this change? ``` yarn flow dom-browser yarn test ``` DiffTrain build for commit e91142d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
came across these TODOs – an internal grep indicated that remaining callsites have been cleaned up, so these can now be removed.
How did you test this change?