integrate scheduler.yield in SchedulerPostTask #27069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahlemen
force-pushed
the
scheduler-yield
branch
from
38629af to
213adc9
Compare
noahlemen
commented
Jul 10, 2023
| // $FlowFixMe[cannot-resolve-module] | ||
| require('SchedulerFeatureFlags'); | ||
|
|
||
| export const enableSchedulerDebugging = true; | ||
| export const enableProfiling: boolean = | ||
| __PROFILE__ && enableProfilingFeatureFlag; | ||
| export const enableSchedulerYield = enableSchedulerYieldFeatureFlag; |
There was a problem hiding this comment.
i had overlooked updating this before, which is (apparently) what broke the build with these changes
There was a problem hiding this comment.
Is Meta actually running the postTask build anywhere? I don't think there's much benefit to switching to postTask unless we can also use yield so maybe we can skip this feature flag and just bundle the postTask + yield changes together.
There was a problem hiding this comment.
no, we're not - that's a good point.
the only justification for the flag i can think of is that A/Bing the PostTask scheduler with and without yield might provide better signal for giving feedback to the chrome team for the origin trial?
There was a problem hiding this comment.
Personally I'd rather just kill any flag that we don't have a solid reason for, it's already too complicated. But I'll leave it up to you.
acdlite
approved these changes
Jul 11, 2023
noahlemen
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
## Summary `scheduler.yield` is entering [Origin Trial soon in Chrome 115](https://chromestatus.com/feature/6266249336586240). This diff adds it to `SchedulerPostTask` when scheduling continuations to allow Origin Trial participation for early feedback on the new API. It seems the difference here versus the current use of `postTask` will be minor – the intent behind `scheduler.yield` seems to mostly be better ergonomics for scheduling continuations, but it may be interesting to see if the follow aspect of it results in any tangible difference in scheduling (from [here](https://github.com/WICG/scheduling-apis/blob/main/explainers/yield-and-continuation.md#introduction)): > To mitigate yielding performance penalty concerns, UAs prioritize scheduler.yield() continuations over tasks of the same priority or similar task sources. ## How did you test this change? ``` yarn test SchedulerPostTask ``` DiffTrain build for [0a36064](0a36064)
styfle
added a commit
to vercel/next.js
that referenced
this pull request
Jul 13, 2023
### React upstream changes - facebook/react#27096 - facebook/react#27069 - facebook/react#27033 - facebook/react#27061 - facebook/react#27030 - facebook/react#27056
|
there is another scheduler.postTask in line 110. |
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary `scheduler.yield` is entering [Origin Trial soon in Chrome 115](https://chromestatus.com/feature/6266249336586240). This diff adds it to `SchedulerPostTask` when scheduling continuations to allow Origin Trial participation for early feedback on the new API. It seems the difference here versus the current use of `postTask` will be minor – the intent behind `scheduler.yield` seems to mostly be better ergonomics for scheduling continuations, but it may be interesting to see if the follow aspect of it results in any tangible difference in scheduling (from [here](https://github.com/WICG/scheduling-apis/blob/main/explainers/yield-and-continuation.md#introduction)): > To mitigate yielding performance penalty concerns, UAs prioritize scheduler.yield() continuations over tasks of the same priority or similar task sources. ## How did you test this change? ``` yarn test SchedulerPostTask ```
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
## Summary `scheduler.yield` is entering [Origin Trial soon in Chrome 115](https://chromestatus.com/feature/6266249336586240). This diff adds it to `SchedulerPostTask` when scheduling continuations to allow Origin Trial participation for early feedback on the new API. It seems the difference here versus the current use of `postTask` will be minor – the intent behind `scheduler.yield` seems to mostly be better ergonomics for scheduling continuations, but it may be interesting to see if the follow aspect of it results in any tangible difference in scheduling (from [here](https://github.com/WICG/scheduling-apis/blob/main/explainers/yield-and-continuation.md#introduction)): > To mitigate yielding performance penalty concerns, UAs prioritize scheduler.yield() continuations over tasks of the same priority or similar task sources. ## How did you test this change? ``` yarn test SchedulerPostTask ``` DiffTrain build for commit 0a36064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scheduler.yieldis entering Origin Trial soon in Chrome 115. This diff adds it toSchedulerPostTaskwhen scheduling continuations to allow Origin Trial participation for early feedback on the new API.It seems the difference here versus the current use of
postTaskwill be minor – the intent behindscheduler.yieldseems to mostly be better ergonomics for scheduling continuations, but it may be interesting to see if the follow aspect of it results in any tangible difference in scheduling (from here):How did you test this change?