rename SuspenseList export to unstable_SuspenseList (facebook#27061)

## Summary as we began [discussing yesterday](facebook#27056 (comment)), `SuspenseList` is not actually stable yet, and should likely be exported with the `unstable_` prefix. the conversation yesterday began discussing this in the context of the fb-specific packages, but changing it there without updating everywhere else leads to test failures, so here the change is made across packages. ## How did you test this change? ``` yarn flow dom-browser yarn test ```
EdisonVan · Apr 15, 2024 · 10dfca5 · 10dfca5
1 parent f5a2ed4
commit 10dfca5
Show file tree

Hide file tree

Showing 18 changed files with 24 additions and 21 deletions.
diff --git a/fixtures/stacks/Example.js b/fixtures/stacks/Example.js
@@ -38,7 +38,7 @@ function Example() {
       DisplayName,
       null,
       x(
-        React.SuspenseList,
+        React.unstable_SuspenseList,
         null,
         x(
           NativeClass,

diff --git a/packages/react-devtools-shared/src/__tests__/store-test.js b/packages/react-devtools-shared/src/__tests__/store-test.js
@@ -693,13 +693,13 @@ describe('Store', () => {
       };
       const Wrapper = ({shouldSuspense}) => (
         <React.Fragment>
-          <React.SuspenseList revealOrder="forwards" tail="collapsed">
+          <React.unstable_SuspenseList revealOrder="forwards" tail="collapsed">
             <Component key="A" />
             <React.Suspense fallback={<Loading />}>
               {shouldSuspense ? <SuspendingComponent /> : <Component key="B" />}
             </React.Suspense>
             <Component key="C" />
-          </React.SuspenseList>
+          </React.unstable_SuspenseList>
         </React.Fragment>
       );
 

diff --git a/packages/react-devtools-shell/src/app/SuspenseTree/index.js b/packages/react-devtools-shell/src/app/SuspenseTree/index.js
@@ -8,7 +8,12 @@
  */
 
 import * as React from 'react';
-import {Fragment, Suspense, SuspenseList, useState} from 'react';
+import {
+  Fragment,
+  Suspense,
+  unstable_SuspenseList as SuspenseList,
+  useState,
+} from 'react';
 
 function SuspenseTree(): React.Node {
   return (

diff --git a/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js b/packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
@@ -81,7 +81,7 @@ describe('ReactDOMFizzServer', () => {
     Suspense = React.Suspense;
     use = React.use;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
 
     PropTypes = require('prop-types');

diff --git a/packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
@@ -116,7 +116,7 @@ describe('ReactDOMServerPartialHydration', () => {
     Offscreen = React.unstable_Offscreen;
     useSyncExternalStore = React.useSyncExternalStore;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
 
     const InternalTestUtils = require('internal-test-utils');

diff --git a/packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMServerSuspense-test.internal.js
@@ -30,7 +30,7 @@ function initModules() {
   ReactTestUtils = require('react-dom/test-utils');
   act = require('internal-test-utils').act;
   if (gate(flags => flags.enableSuspenseList)) {
-    SuspenseList = React.SuspenseList;
+    SuspenseList = React.unstable_SuspenseList;
   }
 
   // Make them available to the helpers.

diff --git a/packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js b/packages/react-dom/src/__tests__/ReactWrongReturnPointer-test.js
@@ -29,7 +29,7 @@ beforeEach(() => {
 
   Suspense = React.Suspense;
   if (gate(flags => flags.enableSuspenseList)) {
-    SuspenseList = React.SuspenseList;
+    SuspenseList = React.unstable_SuspenseList;
   }
 
   getCacheForType = React.unstable_getCacheForType;

diff --git a/packages/react-is/src/__tests__/ReactIs-test.js b/packages/react-is/src/__tests__/ReactIs-test.js
@@ -23,7 +23,7 @@ describe('ReactIs', () => {
     ReactIs = require('react-is');
 
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
   });
 

diff --git a/packages/react-reconciler/src/__tests__/ReactContextPropagation-test.js b/packages/react-reconciler/src/__tests__/ReactContextPropagation-test.js
@@ -23,7 +23,7 @@ describe('ReactLazyContextPropagation', () => {
     useContext = React.useContext;
     Suspense = React.Suspense;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
 
     const InternalTestUtils = require('internal-test-utils');

diff --git a/packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js b/packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js
@@ -67,7 +67,7 @@ describe('ReactHooksWithNoopRenderer', () => {
     ContinuousEventPriority =
       require('react-reconciler/constants').ContinuousEventPriority;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
 
     const InternalTestUtils = require('internal-test-utils');

diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js
@@ -19,7 +19,7 @@ describe('ReactSuspenseList', () => {
     Profiler = React.Profiler;
     Suspense = React.Suspense;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
 
     const InternalTestUtils = require('internal-test-utils');

diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseyCommitPhase-test.js b/packages/react-reconciler/src/__tests__/ReactSuspenseyCommitPhase-test.js
@@ -21,7 +21,7 @@ describe('ReactSuspenseyCommitPhase', () => {
     Scheduler = require('scheduler');
     Suspense = React.Suspense;
     if (gate(flags => flags.enableSuspenseList)) {
-      SuspenseList = React.SuspenseList;
+      SuspenseList = React.unstable_SuspenseList;
     }
     Offscreen = React.unstable_Offscreen;
     useMemo = React.useMemo;

diff --git a/packages/react/index.classic.fb.js b/packages/react/index.classic.fb.js
@@ -17,8 +17,6 @@ export {
   PureComponent,
   StrictMode,
   Suspense,
-  SuspenseList,
-  SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList
   cloneElement,
   createContext,
   createElement,
@@ -38,6 +36,7 @@ export {
   unstable_LegacyHidden,
   unstable_Offscreen,
   unstable_Scope,
+  unstable_SuspenseList,
   unstable_getCacheSignal,
   unstable_getCacheForType,
   unstable_useCacheRefresh,

diff --git a/packages/react/index.experimental.js b/packages/react/index.experimental.js
@@ -17,7 +17,6 @@ export {
   PureComponent,
   StrictMode,
   Suspense,
-  SuspenseList,
   cloneElement,
   createContext,
   createElement,
@@ -36,6 +35,7 @@ export {
   unstable_Offscreen,
   unstable_getCacheSignal,
   unstable_getCacheForType,
+  unstable_SuspenseList,
   unstable_useCacheRefresh,
   unstable_useMemoCache,
   useId,

diff --git a/packages/react/index.js b/packages/react/index.js
@@ -40,7 +40,6 @@ export {
   PureComponent,
   StrictMode,
   Suspense,
-  SuspenseList,
   cloneElement,
   createContext,
   createElement,
@@ -59,6 +58,7 @@ export {
   unstable_LegacyHidden,
   unstable_Offscreen,
   unstable_Scope,
+  unstable_SuspenseList,
   unstable_TracingMarker,
   unstable_getCacheSignal,
   unstable_getCacheForType,

diff --git a/packages/react/index.modern.fb.js b/packages/react/index.modern.fb.js
@@ -17,8 +17,6 @@ export {
   PureComponent,
   StrictMode,
   Suspense,
-  SuspenseList,
-  SuspenseList as unstable_SuspenseList, // TODO: Remove once call sights updated to SuspenseList
   cloneElement,
   createContext,
   createElement,
@@ -36,6 +34,7 @@ export {
   unstable_LegacyHidden,
   unstable_Offscreen,
   unstable_Scope,
+  unstable_SuspenseList,
   unstable_getCacheSignal,
   unstable_getCacheForType,
   unstable_useCacheRefresh,

diff --git a/packages/react/src/React.js b/packages/react/src/React.js
@@ -130,7 +130,7 @@ export {
   useTransition,
   startTransition,
   useDeferredValue,
-  REACT_SUSPENSE_LIST_TYPE as SuspenseList,
+  REACT_SUSPENSE_LIST_TYPE as unstable_SuspenseList,
   REACT_LEGACY_HIDDEN_TYPE as unstable_LegacyHidden,
   REACT_OFFSCREEN_TYPE as unstable_Offscreen,
   getCacheSignal as unstable_getCacheSignal,

diff --git a/packages/react/src/ReactSharedSubset.experimental.js b/packages/react/src/ReactSharedSubset.experimental.js
@@ -17,7 +17,6 @@ export {
   Profiler,
   StrictMode,
   Suspense,
-  SuspenseList,
   cloneElement,
   createElement,
   createRef,
@@ -30,6 +29,7 @@ export {
   cache,
   startTransition,
   unstable_DebugTracingMode,
+  unstable_SuspenseList,
   unstable_getCacheSignal,
   unstable_getCacheForType,
   useId,