[react-interactions] Expose host instance to Scope Query function #17341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac263bf:
|
|
@tatermelon CC for review. |
threepointone
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from #17293. Specifically, we added a 2nd argument to the
queryAllNodesScope API. After some internal profiling, I noticed that this pushed engineers towards doing extra work after the query scope, which was a waste of CPU cycles.To avoid doing extra work, this PR changes the API so that we now pass through the host instance to the query function. That means not only does the query function get the previously existing
typeandprops, but it also gets a third argumentinstance. In the case of ReactDOM, this will be the DOM element instance.This then allows for more precise querying of the scope without having to do wasted work after – it can be done as part of the query.