[react-interactions] Expost host instance to Scope Query function (#1…

…7341)
facebook · Nov 11, 2019 · 6cff70a · 6cff70a
1 parent b8f8258
commit 6cff70a
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 33 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberScope.js b/packages/react-reconciler/src/ReactFiberScope.js
@@ -35,17 +35,16 @@ const emptyObject = {};
 
 function collectScopedNodes(
   node: Fiber,
-  fn: (type: string | Object, props: Object) => boolean,
+  fn: (type: string | Object, props: Object, instance: Object) => boolean,
   scopedNodes: Array<any>,
-  searchNode: null | Set<Object>,
 ): void {
   if (enableScopeAPI) {
     if (node.tag === HostComponent) {
-      const instance = getPublicInstance(node.stateNode);
-      const {type, memoizedProps} = node;
+      const {type, memoizedProps, stateNode} = node;
+      const instance = getPublicInstance(stateNode);
       if (
-        (searchNode !== null && searchNode.has(instance)) ||
-        fn(type, memoizedProps || emptyObject) === true
+        instance !== null &&
+        fn(type, memoizedProps || emptyObject, instance) === true
       ) {
         scopedNodes.push(instance);
       }
@@ -56,20 +55,21 @@ function collectScopedNodes(
       child = getSuspenseFallbackChild(node);
     }
     if (child !== null) {
-      collectScopedNodesFromChildren(child, fn, scopedNodes, searchNode);
+      collectScopedNodesFromChildren(child, fn, scopedNodes);
     }
   }
 }
 
 function collectFirstScopedNode(
   node: Fiber,
-  fn: (type: string | Object, props: Object) => boolean,
+  fn: (type: string | Object, props: Object, instance: Object) => boolean,
 ): null | Object {
   if (enableScopeAPI) {
     if (node.tag === HostComponent) {
-      const {type, memoizedProps} = node;
-      if (fn(type, memoizedProps) === true) {
-        return getPublicInstance(node.stateNode);
+      const {type, memoizedProps, stateNode} = node;
+      const instance = getPublicInstance(stateNode);
+      if (instance !== null && fn(type, memoizedProps, instance) === true) {
+        return instance;
       }
     }
     let child = node.child;
@@ -86,20 +86,19 @@ function collectFirstScopedNode(
 
 function collectScopedNodesFromChildren(
   startingChild: Fiber,
-  fn: (type: string | Object, props: Object) => boolean,
+  fn: (type: string | Object, props: Object, instance: Object) => boolean,
   scopedNodes: Array<any>,
-  searchNode: null | Set<Object>,
 ): void {
   let child = startingChild;
   while (child !== null) {
-    collectScopedNodes(child, fn, scopedNodes, searchNode);
+    collectScopedNodes(child, fn, scopedNodes);
     child = child.sibling;
   }
 }
 
 function collectFirstScopedNodeFromChildren(
   startingChild: Fiber,
-  fn: (type: string | Object, props: Object) => boolean,
+  fn: (type: string | Object, props: Object, instance: Object) => boolean,
 ): Object | null {
   let child = startingChild;
   while (child !== null) {
@@ -197,20 +196,18 @@ export function createScopeMethods(
       return currentFiber.memoizedProps;
     },
     queryAllNodes(
-      fn: (type: string | Object, props: Object) => boolean,
-      searchNodes?: Array<Object>,
+      fn: (type: string | Object, props: Object, instance: Object) => boolean,
     ): null | Array<Object> {
       const currentFiber = ((instance.fiber: any): Fiber);
       const child = currentFiber.child;
       const scopedNodes = [];
-      const searchNodeSet = searchNodes ? new Set(searchNodes) : null;
       if (child !== null) {
-        collectScopedNodesFromChildren(child, fn, scopedNodes, searchNodeSet);
+        collectScopedNodesFromChildren(child, fn, scopedNodes);
       }
       return scopedNodes.length === 0 ? null : scopedNodes;
     },
     queryFirstNode(
-      fn: (type: string | Object, props: Object) => boolean,
+      fn: (type: string | Object, props: Object, instance: Object) => boolean,
     ): null | Object {
       const currentFiber = ((instance.fiber: any): Fiber);
       const child = currentFiber.child;

diff --git a/packages/react-reconciler/src/__tests__/ReactScope-test.internal.js b/packages/react-reconciler/src/__tests__/ReactScope-test.internal.js
@@ -72,7 +72,7 @@ describe('ReactScope', () => {
       expect(scopeRef.current).toBe(null);
     });
 
-    it('queryAllNodes() works as intended with included nodes array', () => {
+    it('queryAllNodes() provides the correct host instance', () => {
       const testScopeQuery = (type, props) => type === 'div';
       const TestScope = React.unstable_createScope();
       const scopeRef = React.createRef();
@@ -99,18 +99,20 @@ describe('ReactScope', () => {
       ReactDOM.render(<Test toggle={true} />, container);
       let nodes = scopeRef.current.queryAllNodes(testScopeQuery);
       expect(nodes).toEqual([divRef.current]);
-      nodes = scopeRef.current.queryAllNodes(testScopeQuery, [spanRef.current]);
+      let filterQuery = (type, props, instance) =>
+        instance === spanRef.current || testScopeQuery(type, props);
+      nodes = scopeRef.current.queryAllNodes(filterQuery);
       expect(nodes).toEqual([divRef.current, spanRef.current]);
-      nodes = scopeRef.current.queryAllNodes(testScopeQuery, [
-        spanRef.current,
-        aRef.current,
-      ]);
+      filterQuery = (type, props, instance) =>
+        [spanRef.current, aRef.current].includes(instance) ||
+        testScopeQuery(type, props);
+      nodes = scopeRef.current.queryAllNodes(filterQuery);
       expect(nodes).toEqual([divRef.current, spanRef.current, aRef.current]);
       ReactDOM.render(<Test toggle={false} />, container);
-      nodes = scopeRef.current.queryAllNodes(testScopeQuery, [
-        spanRef.current,
-        aRef.current,
-      ]);
+      filterQuery = (type, props, instance) =>
+        [spanRef.current, aRef.current].includes(instance) ||
+        testScopeQuery(type, props);
+      nodes = scopeRef.current.queryAllNodes(filterQuery);
       expect(nodes).toEqual([aRef.current, divRef.current, spanRef.current]);
       ReactDOM.render(null, container);
       expect(scopeRef.current).toBe(null);

diff --git a/packages/shared/ReactTypes.js b/packages/shared/ReactTypes.js
@@ -170,11 +170,10 @@ export type ReactScopeMethods = {|
   getParent(): null | ReactScopeMethods,
   getProps(): Object,
   queryAllNodes(
-    (type: string | Object, props: Object) => boolean,
-    searchNodes?: Array<Object>,
+    (type: string | Object, props: Object, instance: Object) => boolean,
   ): null | Array<Object>,
   queryFirstNode(
-    (type: string | Object, props: Object) => boolean,
+    (type: string | Object, props: Object, instance: Object) => boolean,
   ): null | Object,
   containsNode(Object): boolean,
 |};