-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-interactions] Add optional searchNodes to Scope.queryAllNodes #17293
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 43f64f4:
|
Size changes (experimental)Details of bundled changes.Comparing: 3452706...43f64f4 react-art
react-dom
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is just what I need! Thank you :D
The experimental React Scopes API has a method available when using a ref called
queryAllNodes
. Previously, this expected only a scope query function, but now with this PR, can additionally take an optional array of DOM nodes that will also be included in the host component search in a scope. This was an internal request, so that we can easily merge different scope queries together, and the existing focused elements without causing bugs in the UI.