Add simple constructor for JSError #39415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48796703 |
Base commit: 5a926c5 |
|
This pull request was exported from Phabricator. Differential Revision: D48796703 |
neildhar
force-pushed
the
export-D48796703
branch
from
d05d38c
to
73ebd22
Compare
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: avp Differential Revision: D48796703 fbshipit-source-id: a6a2a0909ee08746c34d53ef082b954ccf0c60a4
|
This pull request was exported from Phabricator. Differential Revision: D48796703 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: avp Differential Revision: D48796703 fbshipit-source-id: d561a09aa55511c10fa1511632a9fe2002ebbe63
neildhar
force-pushed
the
export-D48796703
branch
from
73ebd22
to
a8d3ef4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48796703 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: avp Differential Revision: D48796703 fbshipit-source-id: 8c3f118e795ddf45dcf910c69768daeb989a732b
neildhar
force-pushed
the
export-D48796703
branch
from
a8d3ef4
to
b6c4ace
Compare
Summary: Pull Request resolved: facebook#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: avp Differential Revision: D48796703 fbshipit-source-id: d1e1219ae4bb68308200619028eab8428e5a700a
|
This pull request was exported from Phabricator. Differential Revision: D48796703 |
neildhar
force-pushed
the
export-D48796703
branch
from
b6c4ace
to
63cf52c
Compare
|
This pull request has been merged in 9faf256. |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/react-native#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: avp Differential Revision: D48796703 fbshipit-source-id: 1c134e8a59ff54be64a5da901e548436d512c21d
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Sep 13, 2023
* main: (1012 commits) Add simple constructor for JSError (facebook#39415) Breaking: per-node pointScaleFactor (facebook#39403) Implement "tickleJS" for Hermes (facebook#39289) Add thread idle indicator (facebook#39206) Unblock `yarn android` on main (facebook#39413) Remove Codegen buck-oss scripts as they're unused (facebook#39422) Immediately dispatch events to the shared C++ infrastructure to support interruptability (facebook#39380) Fix race condition in Binding::reportMount (facebook#39420) Clone free state progression (facebook#39357) fix: return the correct default trait collection (facebook#38214) Read the React Native version and set the new arch flag properly (facebook#39388) Deprecate default_flags in Podfile (facebook#39389) Create Helper to read the package.json from Cocoapods (facebook#39390) Create helper to enforce the New Arch enabled for double released (facebook#39387) Remove layoutContext Drilling (facebook#39401) Remove JNI Binding usage of layoutContext (facebook#39402) Extract isBaselineLayout() (facebook#39400) Refactor and separate layout affected nodes react marker (facebook#39249) Bump AGP to 8.1.1 (facebook#39392) Fix broken Gradle Sync when opening the project with Android Studio (facebook#39412) ...
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 8, 2023
Summary: Original Author: neildhar@meta.com Original Git: ce1957b Original Reviewed By: avp Original Revision: D48796703 X-link: facebook/react-native#39415 Add a simple constructor for `JSError` which does not accept a `jsi::Runtime` and cannot call back into JSI. This guarantees that the constructor cannot recursively invoke itself, leading to stack overflows. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D50992774 fbshipit-source-id: fe3b63040e345f61f8c396d4ec72ded8f6691bf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a simple constructor for
JSErrorwhich does not accept ajsi::Runtimeand cannot call back into JSI. This guarantees that theconstructor cannot recursively invoke itself, leading to stack
overflows.
Changelog: [Internal]
Differential Revision: D48796703