Read the React Native version and set the new arch flag properly #39388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
Base commit: b955d8d |
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
cipolleschi
force-pushed
the
export-D49149212
branch
from
8525d5a
to
5967432
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…ebook#39388) Summary: Pull Request resolved: facebook#39388 This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native. It connects the diffs in the previous changes in the stack. ## Changelog: [iOS][Changed] - Set the new arch flag based on the React Native version. Reviewed By: dmytrorykun Differential Revision: D49149212 fbshipit-source-id: 307ef6af452999ed0ca0779c5c908b8f4f67894a
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…ebook#39388) Summary: Pull Request resolved: facebook#39388 This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native. It connects the diffs in the previous changes in the stack. ## Changelog: [iOS][Changed] - Set the new arch flag based on the React Native version. Reviewed By: dmytrorykun Differential Revision: D49149212 fbshipit-source-id: 628f8bb7531832033551109e0b5062f357409663
cipolleschi
force-pushed
the
export-D49149212
branch
from
5967432
to
73f8cbd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
cipolleschi
force-pushed
the
export-D49149212
branch
from
73f8cbd
to
e0cb6bb
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…ebook#39388) Summary: Pull Request resolved: facebook#39388 This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native. It connects the diffs in the previous changes in the stack. ## Changelog: [iOS][Changed] - Set the new arch flag based on the React Native version. Reviewed By: dmytrorykun Differential Revision: D49149212 fbshipit-source-id: 49bb04e64551ac31f9bc8c676fdde0d2a9dcd1e8
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…ebook#39388) Summary: Pull Request resolved: facebook#39388 This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native. It connects the diffs in the previous changes in the stack. ## Changelog: [iOS][Changed] - Set the new arch flag based on the React Native version. Reviewed By: dmytrorykun Differential Revision: D49149212 fbshipit-source-id: 403f2b90e62bcdda4f8714a85e8950cc8f1c49aa
cipolleschi
force-pushed
the
export-D49149212
branch
from
e0cb6bb
to
fbf5eae
Compare
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: af9efc9c24d3b105263ab940a6a3b072291bdcf9
Summary: This diff introduce an helper to read the content of the React Native package of json from ruby. ## Changelog: [iOS][Added] - Add helper to read the package.json from the cocoapods script. Differential Revision: D49146946 fbshipit-source-id: 2e315948fa2ee02c965c66e21e85d5fdaa3178da
Summary: The Podfile of the Template is using a function called `get_default_flags` to get the default flags. Its behavior is duplicated in both the default value of the `use_react_native!` function and in the body of the same function, making that helper actually redundant. In this change, we are deprecating it so we can remove it in 0.74 with no breakages. Differential Revision: D49147290 fbshipit-source-id: 858134e777671b104088491d572161f9b7dac6ff
…ebook#39388) Summary: Pull Request resolved: facebook#39388 This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native. It connects the diffs in the previous changes in the stack. ## Changelog: [iOS][Changed] - Set the new arch flag based on the React Native version. Reviewed By: dmytrorykun Differential Revision: D49149212 fbshipit-source-id: cd59c698f37021a79eda953056b60d5abf01fc7d
|
This pull request was exported from Phabricator. Differential Revision: D49149212 |
cipolleschi
force-pushed
the
export-D49149212
branch
from
fbf5eae
to
87e3395
Compare
|
This pull request has been merged in a8d2685. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Sep 13, 2023
* main: (1012 commits) Add simple constructor for JSError (facebook#39415) Breaking: per-node pointScaleFactor (facebook#39403) Implement "tickleJS" for Hermes (facebook#39289) Add thread idle indicator (facebook#39206) Unblock `yarn android` on main (facebook#39413) Remove Codegen buck-oss scripts as they're unused (facebook#39422) Immediately dispatch events to the shared C++ infrastructure to support interruptability (facebook#39380) Fix race condition in Binding::reportMount (facebook#39420) Clone free state progression (facebook#39357) fix: return the correct default trait collection (facebook#38214) Read the React Native version and set the new arch flag properly (facebook#39388) Deprecate default_flags in Podfile (facebook#39389) Create Helper to read the package.json from Cocoapods (facebook#39390) Create helper to enforce the New Arch enabled for double released (facebook#39387) Remove layoutContext Drilling (facebook#39401) Remove JNI Binding usage of layoutContext (facebook#39402) Extract isBaselineLayout() (facebook#39400) Refactor and separate layout affected nodes react marker (facebook#39249) Bump AGP to 8.1.1 (facebook#39392) Fix broken Gradle Sync when opening the project with Android Studio (facebook#39412) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change prepare the infra to release and work properly in the dual release mode, making sure that the new architecture is turned on with some versions of react native.
It connects the diffs in the previous changes in the stack.
Changelog:
[iOS][Changed] - Set the new arch flag based on the React Native version.
Differential Revision: D49149212