Create helper to enforce the New Arch enabled for double released #39387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49145515 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…cebook#39387) Summary: This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Reviewed By: dmytrorykun Differential Revision: D49145515
cipolleschi
force-pushed
the
export-D49145515
branch
from
159d13b
to
b8f4408
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49145515 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: b5a3215d1d6eced1938d86e9c34d2a8365160a67
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: a3a71cf3a1fe3892bd95e6b4474435fbd45a7358
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 3e1867cef5f13241faee066264e5febc8d118dd5
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 12, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 786c80eb01214f82643a17600c1c309b376ad49c
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Reviewed By: dmytrorykun Differential Revision: D49145515
cipolleschi
force-pushed
the
export-D49145515
branch
from
b8f4408
to
094e349
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49145515 |
…cebook#39387) Summary: This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Reviewed By: dmytrorykun Differential Revision: D49145515
cipolleschi
force-pushed
the
export-D49145515
branch
from
094e349
to
12c5009
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 555b9d1a3cc4020453c42b313303fd5c8eb5626b
|
This pull request was exported from Phabricator. Differential Revision: D49145515 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 671484a7f7898bafd2e995cd067f095f4a689e99
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 1eb6ebe38ed514b8eb1906997813646d0bd908a1
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: a9a5afd02480f8a819112d2162885184d5038f89
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: 945ebe847bc99ab56b51aa07e10eb853bf95138c
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2023
…cebook#39387) Summary: Pull Request resolved: facebook#39387 This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version ## Changelog: [iOS][Added] - add helper to set New Arch enabled flag based on RN version. Differential Revision: https://internalfb.com/D49145515 fbshipit-source-id: af9efc9c24d3b105263ab940a6a3b072291bdcf9
|
This pull request was successfully merged by @cipolleschi in 67b3622. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 67b3622. |
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Sep 13, 2023
* main: (1012 commits) Add simple constructor for JSError (facebook#39415) Breaking: per-node pointScaleFactor (facebook#39403) Implement "tickleJS" for Hermes (facebook#39289) Add thread idle indicator (facebook#39206) Unblock `yarn android` on main (facebook#39413) Remove Codegen buck-oss scripts as they're unused (facebook#39422) Immediately dispatch events to the shared C++ infrastructure to support interruptability (facebook#39380) Fix race condition in Binding::reportMount (facebook#39420) Clone free state progression (facebook#39357) fix: return the correct default trait collection (facebook#38214) Read the React Native version and set the new arch flag properly (facebook#39388) Deprecate default_flags in Podfile (facebook#39389) Create Helper to read the package.json from Cocoapods (facebook#39390) Create helper to enforce the New Arch enabled for double released (facebook#39387) Remove layoutContext Drilling (facebook#39401) Remove JNI Binding usage of layoutContext (facebook#39402) Extract isBaselineLayout() (facebook#39400) Refactor and separate layout affected nodes react marker (facebook#39249) Bump AGP to 8.1.1 (facebook#39392) Fix broken Gradle Sync when opening the project with Android Studio (facebook#39412) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change creates an helper function and tests to set the right value for the new arch enabled flag based on the react native version
Changelog:
[iOS][Added] - add helper to set New Arch enabled flag based on RN version.
Differential Revision: D49145515